* bug#61201: Installation hint crashes when user names contain at sign
@ 2023-01-31 17:05 Ludovic Courtès
2023-02-24 10:28 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2023-01-31 17:05 UTC (permalink / raw)
To: 61201
A funny thing was reported earlier today on the Café Guix channel:
--8<---------------cut here---------------start------------->8---
$ guix install hello [17:52]
building profile with 5 packages...
hint: Backtrace:
17 (primitive-load "/usr/local/bin/guix")
In guix/ui.scm:
2279:7 16 (run-guix . )
2242:10 15 (run-guix-command _ . )
In ice-9/boot-9.scm:
1752:10 14 (with-exception-handler _ _ #:unwind? _ # )
In guix/status.scm:
835:3 13 ()
815:4 12 (call-with-status-report _ )
In guix/store.scm:
1300:8 11 (call-with-build-handler _ )
1300:8 10 (call-with-build-handler # ?)
In guix/build/syscalls.scm:
1440:3 9 ()
1407:4 8 (call-with-file-lock/no-wait _ _ )
In guix/scripts/package.scm:
325:7 7 (build-and-use-profile _ "/var/guix/profiles/per-user/?" ?)
In guix/ui.scm:
312:5 6 (display-hint _ )
1451:24 5 (texi->plain-text )
In texinfo.scm:
1132:22 4 (parse )
980:31 3 (loop #<input: string 2b6e5926be70> (fragment) _ _ )
967:36 2 (loop #<input: string 2b6e5926be70> #f # ?)
92:2 1 (command-spec )
In ice-9/boot-9.scm:
1685:16 0 (raise-exception _ #:continuable? )
ice-9/boot-9.scm:1685:16: In procedure raise-exception:
Throw to key #E1E1E1">parser-error' with args(#f "Unknown command" univ)'.
--8<---------------cut here---------------end--------------->8---
This is because the user name ends in “@univ…”, which ‘display-hint’
interprets as Texinfo.
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#61201: Installation hint crashes when user names contain at sign
2023-01-31 17:05 bug#61201: Installation hint crashes when user names contain at sign Ludovic Courtès
@ 2023-02-24 10:28 ` Ludovic Courtès
2023-02-24 11:18 ` Csepp
[not found] ` <20230224104004.19319-1-ludo@gnu.org>
0 siblings, 2 replies; 4+ messages in thread
From: Ludovic Courtès @ 2023-02-24 10:28 UTC (permalink / raw)
To: 61201
Ludovic Courtès <ludovic.courtes@inria.fr> skribis:
> A funny thing was reported earlier today on the Café Guix channel:
>
> $ guix install hello [17:52]
> building profile with 5 packages...
> hint: Backtrace:
[...]
> In guix/ui.scm:
> 312:5 6 (display-hint _ )
> 1451:24 5 (texi->plain-text )
> In texinfo.scm:
> 1132:22 4 (parse )
> 980:31 3 (loop #<input: string 2b6e5926be70> (fragment) _ _ )
> 967:36 2 (loop #<input: string 2b6e5926be70> #f # ?)
> 92:2 1 (command-spec )
> In ice-9/boot-9.scm:
> 1685:16 0 (raise-exception _ #:continuable? )
>
> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> Throw to key #E1E1E1">parser-error' with args(#f "Unknown command" univ)'.
Here’s one way to reproduce the bug, showing a crash in ‘display-hint’
due to an unescaped brace:
--8<---------------cut here---------------start------------->8---
$ mkdir /tmp/x{ample
$ touch /tmp/x{ample/guix.scm
$ (cd '/tmp/x{ample' ; guix shell)
guix shell: error: not loading '/tmp/x{ample/guix.scm' because not authorized to do so
hint: Backtrace:
13 (primitive-load "/home/ludo/.config/guix/current/bin/guix")
In guix/ui.scm:
2279:7 12 (run-guix . _)
2242:10 11 (run-guix-command _ . _)
In ice-9/boot-9.scm:
1752:10 10 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
In guix/scripts/shell.scm:
308:15 9 (_)
In guix/ui.scm:
312:5 8 (display-hint _ _)
1451:24 7 (texi->plain-text _)
In texinfo.scm:
1132:22 6 (parse _)
980:31 5 (loop #<input: string 7feb8b300d20> (*fragment*) _ _ _)
980:31 4 (loop #<input: string 7feb8b300d20> #f _ _ _)
911:31 3 (loop #<input: string 7feb8b300d20> #f #<procedure identity (x)> #f _)
746:27 2 (_ #<input: string 7feb8b300d20> #f (example smallexample verbatim lisp smalllisp menu w %) #<procedure 7feb9aea1948 at texin…> …)
In sxml/ssax/input-parse.scm:
88:2 1 (next-token _ _ _ _)
In ice-9/boot-9.scm:
1685:16 0 (raise-exception _ #:continuable? _)
ice-9/boot-9.scm:1685:16: In procedure raise-exception:
Throw to key `parser-error' with args `(#<input: string 7feb8b300d20> "EOF while reading a token " "reading char data")'.
--8<---------------cut here---------------end--------------->8---
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#61201: Installation hint crashes when user names contain at sign
2023-02-24 10:28 ` Ludovic Courtès
@ 2023-02-24 11:18 ` Csepp
[not found] ` <20230224104004.19319-1-ludo@gnu.org>
1 sibling, 0 replies; 4+ messages in thread
From: Csepp @ 2023-02-24 11:18 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 61201
Ludovic Courtès <ludo@gnu.org> writes:
> Ludovic Courtès <ludovic.courtes@inria.fr> skribis:
>
>> A funny thing was reported earlier today on the Café Guix channel:
>>
>> $ guix install hello [17:52]
>> building profile with 5 packages...
>> hint: Backtrace:
>
> [...]
>
>> In guix/ui.scm:
>> 312:5 6 (display-hint _ )
>> 1451:24 5 (texi->plain-text )
>> In texinfo.scm:
>> 1132:22 4 (parse )
>> 980:31 3 (loop #<input: string 2b6e5926be70> (fragment) _ _ )
>> 967:36 2 (loop #<input: string 2b6e5926be70> #f # ?)
>> 92:2 1 (command-spec )
>> In ice-9/boot-9.scm:
>> 1685:16 0 (raise-exception _ #:continuable? )
>>
>> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
>> Throw to key #E1E1E1">parser-error' with args(#f "Unknown command" univ)'.
>
> Here’s one way to reproduce the bug, showing a crash in ‘display-hint’
> due to an unescaped brace:
>
> $ mkdir /tmp/x{ample
> $ touch /tmp/x{ample/guix.scm
> $ (cd '/tmp/x{ample' ; guix shell)
> guix shell: error: not loading '/tmp/x{ample/guix.scm' because not authorized to do so
> hint: Backtrace:
> 13 (primitive-load "/home/ludo/.config/guix/current/bin/guix")
> In guix/ui.scm:
> 2279:7 12 (run-guix . _)
> 2242:10 11 (run-guix-command _ . _)
> In ice-9/boot-9.scm:
> 1752:10 10 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
> In guix/scripts/shell.scm:
> 308:15 9 (_)
> In guix/ui.scm:
> 312:5 8 (display-hint _ _)
> 1451:24 7 (texi->plain-text _)
> In texinfo.scm:
> 1132:22 6 (parse _)
> 980:31 5 (loop #<input: string 7feb8b300d20> (*fragment*) _ _ _)
> 980:31 4 (loop #<input: string 7feb8b300d20> #f _ _ _)
> 911:31 3 (loop #<input: string 7feb8b300d20> #f #<procedure identity (x)> #f _)
> 746:27 2 (_ #<input: string 7feb8b300d20> #f (example smallexample verbatim lisp smalllisp menu w %) #<procedure 7feb9aea1948 at texin…> …)
> In sxml/ssax/input-parse.scm:
> 88:2 1 (next-token _ _ _ _)
> In ice-9/boot-9.scm:
> 1685:16 0 (raise-exception _ #:continuable? _)
>
> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> Throw to key `parser-error' with args `(#<input: string 7feb8b300d20> "EOF while reading a token " "reading char data")'.
>
> Ludo’.
Would it be heresy to recommend that plain strings and strings that
contain texinfo markup be separate types to catch this sort of thing?
In 2023 it's pretty embarrassing to have bugs that are basically SQL
injections.
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <20230224104004.19319-1-ludo@gnu.org>]
* bug#61201: bug#61749: [PATCH] ui: 'display-hint' quotes extra arguments for Texinfo.
[not found] ` <20230224104004.19319-1-ludo@gnu.org>
@ 2023-02-27 22:55 ` Ludovic Courtès
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2023-02-27 22:55 UTC (permalink / raw)
To: 61749-done; +Cc: 61201-done
Ludovic Courtès <ludo@gnu.org> skribis:
> Fixes <https://issues.guix.gnu.org/61201>.
>
> Previously, common practice was to splice arbitrary strings (user names,
> file names, etc.) into Texinfo snippets passed to 'display-hint'. This
> is unsafe in the general case because at signs and braces need to be
> escaped to produced valid Texinfo. This commit addresses that.
>
> * guix/ui.scm (texinfo-quote): New procedure.
> (display-hint): When ARGUMENTS is non-empty, pass it to 'texinfo-quote'
> and call 'format'.
> (report-unbound-variable-error, check-module-matches-file)
> (display-collision-resolution-hint, run-guix-command): Remove explicit
> 'format' call; pass 'format' arguments as extra arguments to 'display-hint'.
> * gnu/services/monitoring.scm (zabbix-front-end-config): Likewise.
> * guix/scripts.scm (warn-about-disk-space): Likewise.
> * guix/scripts/build.scm (%standard-cross-build-options)
> (%standard-native-build-options): Likewise.
> * guix/scripts/describe.scm (display-checkout-info): Likewise.
> * guix/scripts/environment.scm (suggest-command-name): Likewise.
> * guix/scripts/home.scm (process-command): Likewise.
> * guix/scripts/home/edit.scm (service-type-not-found): Likewise.
> * guix/scripts/import.scm (guix-import): Likewise.
> * guix/scripts/package.scm (display-search-path-hint): Likewise.
> * guix/scripts/pull.scm (build-and-install): Likewise.
> * guix/scripts/shell.scm (auto-detect-manifest): Likewise.
> * guix/scripts/system.scm (check-file-system-availability): Likewise.
> (guix-system): Likewise.
> * guix/scripts/system/edit.scm (service-type-not-found): Likewise.
> * guix/status.scm (print-build-event): Likewise.
Pushed as 43c36c5c9f7a31649eb059fd16ed82bde20da3fc.
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-27 22:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31 17:05 bug#61201: Installation hint crashes when user names contain at sign Ludovic Courtès
2023-02-24 10:28 ` Ludovic Courtès
2023-02-24 11:18 ` Csepp
[not found] ` <20230224104004.19319-1-ludo@gnu.org>
2023-02-27 22:55 ` bug#61201: bug#61749: [PATCH] ui: 'display-hint' quotes extra arguments for Texinfo Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).