From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uAPLC/Kd+GPvswAAbAwnHQ (envelope-from ) for ; Fri, 24 Feb 2023 12:22:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0NMZC/Kd+GN2AQAA9RJhRA (envelope-from ) for ; Fri, 24 Feb 2023 12:22:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F264817A3C for ; Fri, 24 Feb 2023 12:22:25 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b="i/X8WHKN"; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677237746; a=rsa-sha256; cv=none; b=USOd1fZ5lxsBSHjySP2qBgc4z5XVgDNWUHWn88yLoGbOm/EHJ/7H4GjsxS6uHVFUwN4OD1 JJGXRKr9AyHRIoj2WvbYS3GKNZUPT61wMgTa0nxhqMxTX9FHDMocrByasN6XGoP4GBoQgt fDkSEdl6jyAp30gqo+pXos4K7kX9VME9HT+VyOYVYl6FXa9xDVVo5G4Wvhdtfe7ncQyjTN G8AqFJ9jEGByvCsLOPwFEu55j+DNd4ODU5mja8Ri/1tnseDvfSFCq2qMc7mgrrRTw8Sk9/ qPOtziHYehhEQ0/JRgt4NOI06SskbstTgV25G3yDdj/JPlFEiohomt+ZfmJ13g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b="i/X8WHKN"; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677237746; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CmRPe+Ss90rLXqCc9LMrW4PHQReDiu1DZ97Hl64cBCI=; b=b0tK71e3q+Jxfppck3+V6K5Po6vlKD3ki5bozn6Q6qcbkLoc9WKK1E5OiFQ6iAr888LlkC 2x3DsRgyMiDKBaDk2rf09DAsgQGmXU7v4GJI0RKp7CmpwwdtMcK0UyZrjD6VKhn3a5pghi 1QxSJRiEXZA4ZsTSsbmi31QTIfn0qzGqOSNa4AhitBYrunHqty9L/S2Q+tjiDJsoKzf52x Qss9ar2vN9QHl9K5sUuudKt8ybypzPDA0VVSIy8lERM6LNfFasAwO2DwbKJNCGPVl0o1dH f0Ko79GAtYzh5lsvp69Bt7YItSv6ZJYSaHQF+xsfBB/RWGgLN+DxMOHY64F9kw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVW9Q-0007GT-ID; Fri, 24 Feb 2023 06:22:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVW9L-0007Fs-7M for bug-guix@gnu.org; Fri, 24 Feb 2023 06:22:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVW9K-0001WQ-V3 for bug-guix@gnu.org; Fri, 24 Feb 2023 06:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVW9K-0005pP-Qo for bug-guix@gnu.org; Fri, 24 Feb 2023 06:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61201: Installation hint crashes when user names contain at sign Resent-From: Csepp Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 24 Feb 2023 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61201@debbugs.gnu.org X-Debbugs-Original-Cc: bug-guix@gnu.org, 61201@debbugs.gnu.org Received: via spool by 61201-submit@debbugs.gnu.org id=B61201.167723766822327 (code B ref 61201); Fri, 24 Feb 2023 11:22:02 +0000 Received: (at 61201) by debbugs.gnu.org; 24 Feb 2023 11:21:08 +0000 Received: from localhost ([127.0.0.1]:36072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVW8S-0005o2-6D for submit@debbugs.gnu.org; Fri, 24 Feb 2023 06:21:08 -0500 Received: from mx1.riseup.net ([198.252.153.129]:34374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVW8Q-0005n9-JD for 61201@debbugs.gnu.org; Fri, 24 Feb 2023 06:21:07 -0500 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4PNSBP0tkXzDqhC; Fri, 24 Feb 2023 11:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1677237661; bh=JqmNmdOQ9q5xm6077fAnkaCds2LmazVamJh3mC9pMxM=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=i/X8WHKNuNGRNFiVD34xS5I1wuWDISRKA1ysAnoHZv8nWk+XPlQF3A9Ppr/lszOgw gwlujGwRZufut/DBB7QLY1ilK9ziFT6hpVqnZx7xGnvwXHl982TM9B0YGZkQSH9J8z wtSTtM/8bYzqGvePSs1rXPgBSSjg01byKGVUuYV8= X-Riseup-User-ID: 28761947B21C0B8242D27141D73C0A26374C39310E3E7EE1E4BD54D866E6722C Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4PNSBN3DgLz1y7V; Fri, 24 Feb 2023 11:21:00 +0000 (UTC) References: <87edratz17.fsf@inria.fr> <87sfev2w8k.fsf@gnu.org> From: Csepp Date: Fri, 24 Feb 2023 12:18:36 +0100 In-reply-to: <87sfev2w8k.fsf@gnu.org> Message-ID: <87h6vbjomm.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: F264817A3C X-Spam-Score: -2.18 X-Migadu-Spam-Score: -2.18 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: 8U46zy0//RlQ Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> A funny thing was reported earlier today on the Caf=C3=A9 Guix channel: >> >> $ guix install hello [17:52] >> building profile with 5 packages... >> hint: Backtrace: > > [...] > >> In guix/ui.scm: >> 312:5 6 (display-hint _ ) >> 1451:24 5 (texi->plain-text ) >> In texinfo.scm: >> 1132:22 4 (parse ) >> 980:31 3 (loop # (fragment) _ _ ) >> 967:36 2 (loop # #f # ?) >> 92:2 1 (command-spec ) >> In ice-9/boot-9.scm: >> 1685:16 0 (raise-exception _ #:continuable? ) >>=20=20 >> ice-9/boot-9.scm:1685:16: In procedure raise-exception: >> Throw to key #E1E1E1">parser-error' with args(#f "Unknown command" univ)= '. > > Here=E2=80=99s one way to reproduce the bug, showing a crash in =E2=80=98= display-hint=E2=80=99 > due to an unescaped brace: > > $ mkdir /tmp/x{ample > $ touch /tmp/x{ample/guix.scm > $ (cd '/tmp/x{ample' ; guix shell) > guix shell: error: not loading '/tmp/x{ample/guix.scm' because not author= ized to do so > hint: Backtrace: > 13 (primitive-load "/home/ludo/.config/guix/current/bin/guix") > In guix/ui.scm: > 2279:7 12 (run-guix . _) > 2242:10 11 (run-guix-command _ . _) > In ice-9/boot-9.scm: > 1752:10 10 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) > In guix/scripts/shell.scm: > 308:15 9 (_) > In guix/ui.scm: > 312:5 8 (display-hint _ _) > 1451:24 7 (texi->plain-text _) > In texinfo.scm: > 1132:22 6 (parse _) > 980:31 5 (loop # (*fragment*) _ _ _) > 980:31 4 (loop # #f _ _ _) > 911:31 3 (loop # #f # #f _) > 746:27 2 (_ # #f (example smallexample ve= rbatim lisp smalllisp menu w %) #= =E2=80=A6) > In sxml/ssax/input-parse.scm: > 88:2 1 (next-token _ _ _ _) > In ice-9/boot-9.scm: > 1685:16 0 (raise-exception _ #:continuable? _) > > ice-9/boot-9.scm:1685:16: In procedure raise-exception: > Throw to key `parser-error' with args `(# "EO= F while reading a token " "reading char data")'. > > Ludo=E2=80=99. Would it be heresy to recommend that plain strings and strings that contain texinfo markup be separate types to catch this sort of thing? In 2023 it's pretty embarrassing to have bugs that are basically SQL injections.