From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27563@debbugs.gnu.org
Subject: bug#27563: [PATCH] gnu: ghostscript: Don't write document UUID; use "" as instance UUID.
Date: Fri, 07 Jul 2017 13:55:16 +0200 [thread overview]
Message-ID: <8737a8bgwr.fsf@gnu.org> (raw)
In-Reply-To: <20170706090754.4399-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Thu, 6 Jul 2017 11:07:54 +0200")
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * gnu/packages/patches/ghostscript-no-header-uuid.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/ghostscript.scm (ghostscript)[source]: Use it.
[...]
> --- /dev/null
> +++ b/gnu/packages/patches/ghostscript-no-header-uuid.patch
> @@ -0,0 +1,28 @@
> +--- a/devices/vector/gdevpdfe.c 2017-07-06 10:22:28.131889858 +0200
> ++++ b/devices/vector/gdevpdfe.c 2017-07-06 10:24:25.137842222 +0200
Please add a comment at the top of the patch to explain what it does and
what its upstream status is or if there were discussions around it.
> + pdf_xml_tag_open_beg(s, "rdf:Description");
> +- pdf_xml_attribute_name(s, "rdf:about");
> +- pdf_xml_attribute_value(s, instance_uuid);
> +- pdf_xml_attribute_name(s, "xmlns:xapMM");
> +- pdf_xml_attribute_value(s, "http://ns.adobe.com/xap/1.0/mm/");
> +- pdf_xml_attribute_name(s, "xapMM:DocumentID");
> +- pdf_xml_attribute_value(s, document_uuid);
> +- pdf_xml_tag_end_empty(s);
> +- pdf_xml_newline(s);
> +-
> +- pdf_xml_tag_open_beg(s, "rdf:Description");
What’s the impact of simply removing all of this from generated PDF
files? Should we instead make it optional? For instance, we could
introduce a new environment variable, say “GHOSTSCRIPT_PDF_UUID”, and
use that as the document UUID when it’s defined. In our build
environments, we’d always set GHOSTSCRIPT_PDF_UUID to a known value to
ensure determinism.
WDYT?
Also, what does Debian do? :-)
Thank you for working on it!
Ludo’.
next prev parent reply other threads:[~2017-07-07 11:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 18:08 bug#27563: ghostscript-with-cups is not reproducible Danny Milosavljevic
2017-07-03 18:16 ` bug#27563: [PATCH] gnu: ghostscript: Add phase "remove-timestamps" Danny Milosavljevic
2017-07-03 19:18 ` Efraim Flashner
2017-07-05 21:57 ` Ludovic Courtès
2017-07-04 19:08 ` Leo Famulari
2017-07-03 19:46 ` bug#27563: [PATCH v2] gnu: ghostscript: Remove timestamps Danny Milosavljevic
2017-07-06 9:07 ` bug#27563: [PATCH] gnu: ghostscript: Don't write document UUID; use "" as instance UUID Danny Milosavljevic
2017-07-07 11:55 ` Ludovic Courtès [this message]
2017-07-07 13:28 ` Danny Milosavljevic
2017-07-06 10:32 ` bug#27563: [PATCH v3 0/2] Make ghostscript reproducible Danny Milosavljevic
2017-07-06 10:32 ` bug#27563: [PATCH v3 1/2] gnu: ghostscript: Don't write document UUID; use "" as instance UUID Danny Milosavljevic
2017-07-06 10:32 ` bug#27563: [PATCH v3 2/2] gnu: ghostscript: Write document ID only when encrypting Danny Milosavljevic
2017-07-07 12:02 ` Ludovic Courtès
2017-07-07 13:21 ` Danny Milosavljevic
2017-07-07 16:21 ` Leo Famulari
2017-07-07 16:42 ` Danny Milosavljevic
2017-07-07 17:24 ` Leo Famulari
2017-07-08 13:50 ` Leo Famulari
2017-07-07 17:45 ` Ludovic Courtès
2017-07-07 12:00 ` bug#27563: [PATCH v3 0/2] Make ghostscript reproducible Ludovic Courtès
2017-07-07 13:25 ` Danny Milosavljevic
2017-07-07 15:18 ` Ludovic Courtès
2017-07-07 15:44 ` Danny Milosavljevic
2017-07-07 17:51 ` Ludovic Courtès
2017-07-07 18:20 ` Danny Milosavljevic
2017-07-08 14:32 ` Ludovic Courtès
2017-07-09 23:40 ` bug#27563: [PATCH v4 0/3] " Danny Milosavljevic
2017-07-09 23:46 ` bug#27563: [PATCH v4 1/3] gnu: ghostscript: Make "/ID" optional, depending on environment variable Danny Milosavljevic
2017-07-09 23:46 ` bug#27563: [PATCH v4 2/3] gnu: ghostscript: Make XMP UUID headers " Danny Milosavljevic
2017-07-10 15:23 ` Ludovic Courtès
2017-07-09 23:46 ` bug#27563: [PATCH v4 3/3] gnu: ghostscript: Make "/CreationDate", "/ModDate" optoinal, " Danny Milosavljevic
2017-07-10 15:25 ` Ludovic Courtès
2017-07-10 15:21 ` bug#27563: [PATCH v4 1/3] gnu: ghostscript: Make "/ID" optional, " Ludovic Courtès
2017-07-10 16:35 ` bug#27563: [PATCH v4 0/3] Make ghostscript reproducible Danny Milosavljevic
2017-07-07 15:34 ` bug#27563: [PATCH v3 0/2] " Danny Milosavljevic
2017-07-07 17:46 ` Ludovic Courtès
2017-07-06 10:59 ` bug#27563: ghostscript-with-cups is not reproducible Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737a8bgwr.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27563@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).