From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#27563: [PATCH] gnu: ghostscript: Don't write document UUID;
	use "" as instance UUID.
Date: Fri, 07 Jul 2017 13:55:16 +0200
Message-ID: <8737a8bgwr.fsf@gnu.org>
References: <20170703200844.3f6d9e19@scratchpost.org>
	<20170706090754.4399-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56572)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dTRrh-00026c-OH
	for bug-guix@gnu.org; Fri, 07 Jul 2017 07:56:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dTRre-000260-Kz
	for bug-guix@gnu.org; Fri, 07 Jul 2017 07:56:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:53109)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dTRre-00025q-Hp
	for bug-guix@gnu.org; Fri, 07 Jul 2017 07:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dTRre-0006Iv-8D
	for bug-guix@gnu.org; Fri, 07 Jul 2017 07:56:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27563.B27563.149942853424200@debbugs.gnu.org>
In-Reply-To: <20170706090754.4399-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Thu, 6 Jul 2017 11:07:54 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27563@debbugs.gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/patches/ghostscript-no-header-uuid.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/ghostscript.scm (ghostscript)[source]: Use it.

[...]

> --- /dev/null
> +++ b/gnu/packages/patches/ghostscript-no-header-uuid.patch
> @@ -0,0 +1,28 @@
> +--- a/devices/vector/gdevpdfe.c	2017-07-06 10:22:28.131889858 +0200
> ++++ b/devices/vector/gdevpdfe.c	2017-07-06 10:24:25.137842222 +0200

Please add a comment at the top of the patch to explain what it does and
what its upstream status is or if there were discussions around it.

> +             pdf_xml_tag_open_beg(s, "rdf:Description");
> +-            pdf_xml_attribute_name(s, "rdf:about");
> +-            pdf_xml_attribute_value(s, instance_uuid);
> +-            pdf_xml_attribute_name(s, "xmlns:xapMM");
> +-            pdf_xml_attribute_value(s, "http://ns.adobe.com/xap/1.0/mm/=
");
> +-            pdf_xml_attribute_name(s, "xapMM:DocumentID");
> +-            pdf_xml_attribute_value(s, document_uuid);
> +-            pdf_xml_tag_end_empty(s);
> +-            pdf_xml_newline(s);
> +-
> +-            pdf_xml_tag_open_beg(s, "rdf:Description");

What=E2=80=99s the impact of simply removing all of this from generated PDF
files?  Should we instead make it optional?  For instance, we could
introduce a new environment variable, say =E2=80=9CGHOSTSCRIPT_PDF_UUID=E2=
=80=9D, and
use that as the document UUID when it=E2=80=99s defined.  In our build
environments, we=E2=80=99d always set GHOSTSCRIPT_PDF_UUID to a known value=
 to
ensure determinism.

WDYT?

Also, what does Debian do?  :-)

Thank you for working on it!

Ludo=E2=80=99.