bug#53559: Mutter test-suite is flaky

bug#53559: Mutter test-suite is flaky

[Liliana Marie Prikler]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

Hi Guix,

ever since the merge of core-updates-frozen, I've been unable to build
mutter locally, while fetching it from CI is usually fine.  Attached is
a build log -- note, that the traceback is generated by me killing the
process with a SIGSEGV, it would otherwise go on for several days.

Cheers

[-- Attachment #2: nx8rx7gy5xbra7060arkwmwks5lpw3-mutter-41.0.drv.bz2 --]
[-- Type: application/x-bzip, Size: 40753 bytes --]

bug#53559: [PATCH] gnu: mutter: Disable timeline tests.

[Liliana Marie Prikler]

* gnu/packages/gnome.scm (mutter)[disable-problematic-tests]: Also disable
timeline tests.
---
 gnu/packages/gnome.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index e3fac534c4..b341fb4c97 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7477,7 +7477,11 @@ (define-public mutter
              ;; expression paragraph.  For an explanation, see: info '(sed)
              ;; Multiline techniques'.
              (invoke "sed" "/./{H;$!d} ; x ; s/^.*native-headless.*$//"
-                     "-i" "src/tests/meson.build")))
+                     "-i" "src/tests/meson.build")
+             ;; Timeline tests may unexpectedly fail on missed frames, so
+             ;; let's disable them as well.
+             (substitute* "src/tests/clutter/conform/meson.build"
+               (("'timeline.*',") ""))))
          (replace 'check
            (lambda* (#:key tests? test-options parallel-tests?
                      #:allow-other-keys)
-- 
2.34.0

bug#53559: Mutter test-suite is flaky

[Maxim Cournoyer]

Hello Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/gnome.scm (mutter)[disable-problematic-tests]: Also disable
> timeline tests.
> ---
>  gnu/packages/gnome.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index e3fac534c4..b341fb4c97 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -7477,7 +7477,11 @@ (define-public mutter
>               ;; expression paragraph.  For an explanation, see: info '(sed)
>               ;; Multiline techniques'.
>               (invoke "sed" "/./{H;$!d} ; x ; s/^.*native-headless.*$//"
> -                     "-i" "src/tests/meson.build")))
> +                     "-i" "src/tests/meson.build")
> +             ;; Timeline tests may unexpectedly fail on missed frames, so
> +             ;; let's disable them as well.
> +             (substitute* "src/tests/clutter/conform/meson.build"
> +               (("'timeline.*',") ""))))
>           (replace 'check
>             (lambda* (#:key tests? test-options parallel-tests?
>                       #:allow-other-keys)

You'd want to let upstream know about these flaky tests, and add the
reference to the upstream issue in a comment so we can track progress.

Otherwise, LGTM.

Thanks,

Maxim

bug#53559: Mutter test-suite is flaky

[Liliana Marie Prikler]

Am Montag, dem 31.01.2022 um 00:27 -0500 schrieb Maxim Cournoyer:
> You'd want to let upstream know about these flaky tests, and add the
> reference to the upstream issue in a comment so we can track
> progress.
Pushed with said reference.

Cheers