unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 53559@debbugs.gnu.org
Subject: bug#53559: Mutter test-suite is flaky
Date: Mon, 31 Jan 2022 00:27:28 -0500	[thread overview]
Message-ID: <8735l4o4ov.fsf_-_@gmail.com> (raw)
In-Reply-To: <2d54086914eff8218918dad8a43772339177729a.camel@gmail.com> (Liliana Marie Prikler's message of "Thu, 27 Jan 2022 21:47:11 +0100")

Hello Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/gnome.scm (mutter)[disable-problematic-tests]: Also disable
> timeline tests.
> ---
>  gnu/packages/gnome.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index e3fac534c4..b341fb4c97 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -7477,7 +7477,11 @@ (define-public mutter
>               ;; expression paragraph.  For an explanation, see: info '(sed)
>               ;; Multiline techniques'.
>               (invoke "sed" "/./{H;$!d} ; x ; s/^.*native-headless.*$//"
> -                     "-i" "src/tests/meson.build")))
> +                     "-i" "src/tests/meson.build")
> +             ;; Timeline tests may unexpectedly fail on missed frames, so
> +             ;; let's disable them as well.
> +             (substitute* "src/tests/clutter/conform/meson.build"
> +               (("'timeline.*',") ""))))
>           (replace 'check
>             (lambda* (#:key tests? test-options parallel-tests?
>                       #:allow-other-keys)

You'd want to let upstream know about these flaky tests, and add the
reference to the upstream issue in a comment so we can track progress.

Otherwise, LGTM.

Thanks,

Maxim




  reply	other threads:[~2022-01-31  5:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 20:27 bug#53559: Mutter test-suite is flaky Liliana Marie Prikler
2022-01-27 20:47 ` bug#53559: [PATCH] gnu: mutter: Disable timeline tests Liliana Marie Prikler
2022-01-31  5:27   ` Maxim Cournoyer [this message]
2022-02-11 20:25     ` bug#53559: Mutter test-suite is flaky Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735l4o4ov.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=53559@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).