* bug#38884: guix system roll-back doesn't roll setuid-programs back
@ 2020-01-03 0:48 Jakub Kądziołka
2020-09-20 20:43 ` Brice Waegeneire via web
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kądziołka @ 2020-01-03 0:48 UTC (permalink / raw)
To: 38884
Steps to reproduce:
1. Add a setuid program to your config:
(setuid-programs (cons*
(file-append hello "/bin/hello")
%setuid-programs))
2. guix system reconfigure
3. Observe that /run/setuid-programs/hello got created
4. Undo the configuration change
5. guix system reconfigure
6. Observe that /run/setuid-programs/hello no longer exists
7. guix system roll-back
Expected behavior:
/run/setuid-programs/hello appears again
Actual behavior:
/run/setuid-programs/hello still doesn't exist
Similarly, when roll-back is supposed to remove a file, it doesn't.
Previously mentioned in https://debbugs.gnu.org/38800.
Regards,
Jakub Kądziołka
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#38884: guix system roll-back doesn't roll setuid-programs back
2020-01-03 0:48 bug#38884: guix system roll-back doesn't roll setuid-programs back Jakub Kądziołka
@ 2020-09-20 20:43 ` Brice Waegeneire via web
0 siblings, 0 replies; 2+ messages in thread
From: Brice Waegeneire via web @ 2020-09-20 20:43 UTC (permalink / raw)
To: 38884
Hello Guix,
"setuid-programs-service" extend the activation script which isn't loaded when rolling-back.
A difference between "reconfigure" and "switch-generation" (of which "roll-back" is just an useful alias) is that the former load the activation script (guix scripts system reconfigure switch-system-program) after switching the profile's symlinks and before installing the bootloader while the latter install the bootloader (guix scripts system switch-to-system-generation) then switch the symlinks (guix profiles switch-to-generation). Fixing that could be done by loading the activation script after switching profiles, as "reconfigure" does.
I guess that loading the activation script again, on a already running running system, can have side effect but it shouldn't be an issue as it's already done by "reconfigure".
Cheers,
- Brice
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-20 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-03 0:48 bug#38884: guix system roll-back doesn't roll setuid-programs back Jakub Kądziołka
2020-09-20 20:43 ` Brice Waegeneire via web
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).