From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 1gudDOrKZ19STQAA0tVLHw (envelope-from ) for ; Sun, 20 Sep 2020 21:34:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IN1KCOrKZ19BCwAA1q6Kng (envelope-from ) for ; Sun, 20 Sep 2020 21:34:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 135D294065E for ; Sun, 20 Sep 2020 21:29:34 +0000 (UTC) Received: from localhost ([::1]:57054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kK6DJ-00016Z-1m for larch@yhetil.org; Sun, 20 Sep 2020 16:45:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kK6Ck-000169-NX for bug-guix@gnu.org; Sun, 20 Sep 2020 16:45:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kK6Ck-0005xF-DH for bug-guix@gnu.org; Sun, 20 Sep 2020 16:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kK6Cj-0005X0-Sw; Sun, 20 Sep 2020 16:45:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#38884: guix system roll-back doesn't roll setuid-programs back References: <20200103004803.7xmz2dfz6hvs5oak@zdrowyportier.kadziolka.net> In-Reply-To: <20200103004803.7xmz2dfz6hvs5oak@zdrowyportier.kadziolka.net> Resent-From: Brice Waegeneire via web Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org, Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Resent-Date: Sun, 20 Sep 2020 20:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38884 X-GNU-PR-Package: guix X-GNU-PR-Keywords: security To: 38884@debbugs.gnu.org Received: via spool by 38884-submit@debbugs.gnu.org id=B38884.160063464221177 (code B ref 38884); Sun, 20 Sep 2020 20:45:01 +0000 Received: (at 38884) by debbugs.gnu.org; 20 Sep 2020 20:44:02 +0000 Received: from localhost ([127.0.0.1]:52781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK6Bm-0005VV-Fi for submit@debbugs.gnu.org; Sun, 20 Sep 2020 16:44:02 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK6Bj-0005Ux-8j for 38884@debbugs.gnu.org; Sun, 20 Sep 2020 16:44:00 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1600634636; cv=none; d=zohomail.com; s=zohoarc; b=ZwC100er3q7Fq1GkrMtJP60RID7IC3rlAAqd0v7qh6cDMO6NPEwjDwwGDhpgrIUDB/cRgfHXlk0OF11hNbIAIdt0gB+D8XaTwiHZi3Y4OkG3Yf9GJBY7ZfunZMZOiI+F1DZ4HYMaakOI3+oS/VW5jH50DZ4SEA1H/+w5FHEgHxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600634636; h=Content-Type:Date:From:MIME-Version:Message-ID:Subject:To; bh=Dszoyh36ubaWTcxsiO8CYr0b3SCmhuxI6PJCFNZMogo=; b=BLETcrSFFQkT0mu0mByX6VQNf0Ae9L193C3CqqTCn3kmhFiQYUFA6srQxWJhQvtKzMGVePyjnRpFFdtc6rXZLRK8qkC5PFXpVDwr5/PDNPhggRA2xrMGfOZFe50aTcg9fs/hlzm7sy3yejOrBYxQRlZhsJrqPO5cJ7Mchcz9Bk4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=issues.guix.gnu.org@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600634636; s=zoho; d=elephly.net; i=issues.guix.gnu.org@elephly.net; h=MIME-Version:Content-Type:From:To:Date:Message-ID:Subject; bh=Dszoyh36ubaWTcxsiO8CYr0b3SCmhuxI6PJCFNZMogo=; b=bAV6TK5lhnTbC/aWMTe74AAZPbvLxP57+HoVUmSVWCzWd3vQQCZ0321gfOJPu3yo SiYmCZfiHVLJupoYQLk4PJ/Ot56e5neY6AN880BzMQfDoDKqBlnMMdNy1GGzXGKm9RL 4GM2e5nHE/kj6SpZVbKEwVu+9dqkd6ZsLemD5OE4= Received: from localhost (185.220.102.245 [185.220.102.245]) by mx.zohomail.com with SMTPS id 160063463470679.71665733139844; Sun, 20 Sep 2020 13:43:54 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 From: Brice Waegeneire via web Date: Sun, 20 Sep 2020 22:43:48 +0200 Message-ID: <7f8ff855af90.4ca1a3edb126540@guile.gnu.org> X-ZohoMailClient: External X-Spam-Score: 2.5 (++) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: 0.2 (/) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-TUID: 8Y7lFnEurglm Hello Guix, "setuid-programs-service" extend the activation script which isn't loaded when rolling-back. A difference between "reconfigure" and "switch-generation" (of which "roll-back" is just an useful alias) is that the former load the activation script (guix scripts system reconfigure switch-system-program) after switching the profile's symlinks and before installing the bootloader while the latter install the bootloader (guix scripts system switch-to-system-generation) then switch the symlinks (guix profiles switch-to-generation). Fixing that could be done by loading the activation script after switching profiles, as "reconfigure" does. I guess that loading the activation script again, on a already running running system, can have side effect but it shouldn't be an issue as it's already done by "reconfigure". Cheers, - Brice