* bug#57573: disarchive: Test "[prop] Writing is reversible" fails
@ 2022-09-04 8:11 Maxime Devos
2022-09-04 8:24 ` Maxime Devos
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Devos @ 2022-09-04 8:11 UTC (permalink / raw)
To: 57573; +Cc: timothy sample
X-Debbugs-CC: Timothy Sample <samplet@ngyro.com>
Hi,
disarchive fails to build (on core-updates, more precisely as part of
the antiox jobset on ci.guix.gnu.org).
The failing test is:
> test-name: [prop] Writing is reversible
> location: tests/kinds/octal.scm:128
> source:
> + (test-assert
> + "[prop] Writing is reversible"
> + (quickcheck
> + (property
> + ((octal $octal))
> + (test-when
> + (valid-octal? octal)
> + (begin
> + (equal?
> + octal
> + (decode-octal (encode-octal octal))))))))
> Falsifiable after 25 tests.
> Seed: 318171092
> octal = #<<unstructured-octal> value: 0 source: #<<zero-string> value:
> "0" trailer: "?">>
> actual-value: #f
> result: FAIL
(This appears to be a different test failure than in
<https://issues.guix.gnu.org/48114>)
TBI ...
Greetings,
Maxime.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#57573: disarchive: Test "[prop] Writing is reversible" fails
2022-09-04 8:11 bug#57573: disarchive: Test "[prop] Writing is reversible" fails Maxime Devos
@ 2022-09-04 8:24 ` Maxime Devos
2022-09-04 9:05 ` Maxime Devos
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Devos @ 2022-09-04 8:24 UTC (permalink / raw)
To: 57573; +Cc: timothy sample
Here's a reproducer:
(define o (make-unstructured-octal 0 (make-zero-string "0" #\䤄)))
(test-equal "Writing is reversible (#57573)"
o (decode-octal (encode-octal octal)))
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#57573: disarchive: Test "[prop] Writing is reversible" fails
2022-09-04 8:24 ` Maxime Devos
@ 2022-09-04 9:05 ` Maxime Devos
2022-09-08 18:21 ` Timothy Sample
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Devos @ 2022-09-04 9:05 UTC (permalink / raw)
To: 57573; +Cc: timothy sample
On 04-09-2022 10:24, Maxime Devos wrote:
> Here's a reproducer:
>
> (define o (make-unstructured-octal 0 (make-zero-string "0" #\䤄)))
> (test-equal "Writing is reversible (#57573)"
> o (decode-octal (encode-octal octal)))
>
That was bogus (octal is undefined), try
>
> (define o (make-unstructured-octal 0 (make-zero-string "0" "䤄")))
> (unless (valid-octal? o) (error "oops"))
> (test-equal "Writing is reversible (#57573)"
> o (decode-octal (encode-octal o)))
instead. Error message:
> test-name: Writing is reversible (#57573)
> location: tests/kinds/octal.scm:130
> source:
> + (test-equal
> + "Writing is reversible (#57573)"
> + o
> + (decode-octal (encode-octal o)))
> expected-value: #<<unstructured-octal> value: 0 source:
> #<<zero-string> value: "0" trailer: "䤄">>
> actual-value: #<<padded-octal> value: 0 width: 1 padding: #\0 trailer:
> "䤄">
> result: FAIL
Greetings,
Maxime.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#57573: disarchive: Test "[prop] Writing is reversible" fails
2022-09-04 9:05 ` Maxime Devos
@ 2022-09-08 18:21 ` Timothy Sample
0 siblings, 0 replies; 4+ messages in thread
From: Timothy Sample @ 2022-09-08 18:21 UTC (permalink / raw)
To: Maxime Devos; +Cc: 57573
Hi Maxime,
Maxime Devos <maxime.devos@student.kuleuven.be> writes:
> (define o (make-unstructured-octal 0 (make-zero-string "0" "䤄")))
> (unless (valid-octal? o) (error "oops"))
> (test-equal "Writing is reversible (#57573)"
> o (decode-octal (encode-octal o)))
Right. That unstructured octal should be invalid. By the definition in
the code, it has too much “structure”. It’s a test issue, the actual
code is fine. I’ll patch the tests and make a point release in the
coming days.
Thanks for the heads up and the analysis, and sorry for the
inconvenience!
-- Tim
P.S. I’m excited about antioxidant – good work and happy hacking!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-08 18:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-04 8:11 bug#57573: disarchive: Test "[prop] Writing is reversible" fails Maxime Devos
2022-09-04 8:24 ` Maxime Devos
2022-09-04 9:05 ` Maxime Devos
2022-09-08 18:21 ` Timothy Sample
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).