unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: Maxime Devos <maxime.devos@student.kuleuven.be>
Cc: 57573@debbugs.gnu.org
Subject: bug#57573: disarchive: Test "[prop] Writing is reversible" fails
Date: Thu, 08 Sep 2022 12:21:31 -0600	[thread overview]
Message-ID: <871qsllob8.fsf@ngyro.com> (raw)
In-Reply-To: <6a051c77-21f9-c597-7225-727020dccb25@student.kuleuven.be> (Maxime Devos's message of "Sun, 4 Sep 2022 11:05:59 +0200")

Hi Maxime,

Maxime Devos <maxime.devos@student.kuleuven.be> writes:

> (define o (make-unstructured-octal 0 (make-zero-string "0" "䤄")))
> (unless (valid-octal? o) (error "oops"))
> (test-equal "Writing is reversible (#57573)"
>         o (decode-octal (encode-octal o)))

Right.  That unstructured octal should be invalid.  By the definition in
the code, it has too much “structure”.  It’s a test issue, the actual
code is fine.  I’ll patch the tests and make a point release in the
coming days.

Thanks for the heads up and the analysis, and sorry for the
inconvenience!


-- Tim

P.S. I’m excited about antioxidant – good work and happy hacking!




      reply	other threads:[~2022-09-08 18:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-04  8:11 bug#57573: disarchive: Test "[prop] Writing is reversible" fails Maxime Devos
2022-09-04  8:24 ` Maxime Devos
2022-09-04  9:05   ` Maxime Devos
2022-09-08 18:21     ` Timothy Sample [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qsllob8.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=57573@debbugs.gnu.org \
    --cc=maxime.devos@student.kuleuven.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).