unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: 51559@debbugs.gnu.org
Cc: maxim.cournoyer@gmail.com
Subject: bug#51559: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64.
Date: Sat, 6 Nov 2021 09:21:02 +0100	[thread overview]
Message-ID: <5a2e4473e11fef78539f75a86f4cda9c105c44be.camel@gmail.com> (raw)
In-Reply-To: <b228508ab5b8d98cff221050bcf7a41595f90c4a.camel@gmail.com>

* gnu/packages/webkit.scm (webkitgtk)[#:phases]: Add ‘disable-sse2’ if the
current (target) system is not an x86_64 one.
---
Hi Maxime,

I tried conditionally disabling SSE2 on the host side, but for some reason this
patch would cause a rebuild for me.  Did I do something wrong?

 gnu/packages/webkit.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index e54b680855..ca50ab37a8 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -241,7 +241,7 @@ (define-public webkitgtk
     (build-system cmake-build-system)
     (outputs '("out" "doc"))
     (arguments
-     '(#:tests? #f ; no tests
+     `(#:tests? #f ; no tests
        #:build-type "Release" ; turn off debugging symbols to save space
        #:configure-flags (list
                           "-DPORT=GTK"
@@ -295,6 +295,13 @@ (define-public webkitgtk
                  (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
                   (string-append wpebackend-fdo "/lib/" all)))
                #t)))
+         ,@(if (string-prefix? "x68_64" (or (%current-target-system)
+                                            (%current-system)))
+               '()
+               '((add-after 'unpack 'disable-sse2
+                   (lambda _
+                     (substitute* "Source/cmake/DetectSSE2.cmake"
+                       (("CHECK_FOR_SSE2\\(\\)") ""))))))
          (add-before 'configure 'prepare-build-environment
            (lambda* (#:key inputs #:allow-other-keys)
              (setenv "CC" "clang")
-- 
2.33.1






  parent reply	other threads:[~2021-11-06  8:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01 21:02 bug#51559: Webkit fails to build Liliana Marie Prikler
2021-11-02  3:14 ` Maxim Cournoyer
2021-11-02  5:43   ` Mark H Weaver
2021-11-04 18:23     ` Maxim Cournoyer
2021-11-04 19:59       ` Liliana Marie Prikler
2021-11-04 21:58         ` Mark H Weaver
2021-11-05  4:21           ` Maxim Cournoyer
2021-11-05  5:17           ` Liliana Marie Prikler
2021-11-05 20:06 ` bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on x86_64 Liliana Marie Prikler
2021-11-05 20:15   ` Maxime Devos
2021-11-05 22:19     ` Liliana Marie Prikler
2021-11-05 22:38       ` Maxime Devos
2021-11-06  8:00       ` Mark H Weaver
2021-11-06  8:21 ` Liliana Marie Prikler [this message]
2021-11-06  8:44   ` bug#51559: [PATCH v2] gnu: webkit: " Mark H Weaver
2021-11-06  8:55   ` Mark H Weaver
2021-11-06  9:42     ` Liliana Marie Prikler
2021-11-06 18:06       ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a2e4473e11fef78539f75a86f4cda9c105c44be.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=51559@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).