From: Maxime Devos <maximedevos@telenet.be>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>, 51559@debbugs.gnu.org
Cc: maxim.cournoyer@gmail.com
Subject: bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on x86_64.
Date: Fri, 05 Nov 2021 20:15:12 +0000 [thread overview]
Message-ID: <3c36e72879c977e9f1c9fcd485a75d908d2391c5.camel@telenet.be> (raw)
In-Reply-To: <5acdf0477d3c75319d6f6ef668c6323be7ea680e.camel@gmail.com>
Liliana Marie Prikler schreef op vr 05-11-2021 om 21:06 [+0100]:
> * gnu/packages/webkit.scm (webkitgtk)[#:phases]: Add ‘disable-sse2’.
> ---
> gnu/packages/webkit.scm | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
> index e54b680855..45150e185f 100644
> --- a/gnu/packages/webkit.scm
> +++ b/gnu/packages/webkit.scm
> @@ -295,6 +295,11 @@ (define-public webkitgtk
> (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
> (string-append wpebackend-fdo "/lib/" all)))
> #t)))
> + (add-after 'unpack 'disable-sse2
> + (lambda* (#:key system #:allow-other-keys)
> + (unless (string-prefix? "x86_64" system)
IIUC, when cross-compiling, you need to look at 'target', not 'system'.
At least, that's the case if %current-system/%current-target-system is
used. Not sure about 'system' and 'target'.
Suggestion:
(unless ,(target-x86-64?)
(substitute* ...))
Greetings,
Maxime.
next prev parent reply other threads:[~2021-11-05 20:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 21:02 bug#51559: Webkit fails to build Liliana Marie Prikler
2021-11-02 3:14 ` Maxim Cournoyer
2021-11-02 5:43 ` Mark H Weaver
2021-11-04 18:23 ` Maxim Cournoyer
2021-11-04 19:59 ` Liliana Marie Prikler
2021-11-04 21:58 ` Mark H Weaver
2021-11-05 4:21 ` Maxim Cournoyer
2021-11-05 5:17 ` Liliana Marie Prikler
2021-11-05 20:06 ` bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on x86_64 Liliana Marie Prikler
2021-11-05 20:15 ` Maxime Devos [this message]
2021-11-05 22:19 ` Liliana Marie Prikler
2021-11-05 22:38 ` Maxime Devos
2021-11-06 8:00 ` Mark H Weaver
2021-11-06 8:21 ` bug#51559: [PATCH v2] gnu: webkit: " Liliana Marie Prikler
2021-11-06 8:44 ` Mark H Weaver
2021-11-06 8:55 ` Mark H Weaver
2021-11-06 9:42 ` Liliana Marie Prikler
2021-11-06 18:06 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c36e72879c977e9f1c9fcd485a75d908d2391c5.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=51559@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).