From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YLUWJCk9hmEv2AAAgWs5BA (envelope-from ) for ; Sat, 06 Nov 2021 09:30:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2JrHHyk9hmG+DgAAB5/wlQ (envelope-from ) for ; Sat, 06 Nov 2021 08:30:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1A4192C32C for ; Sat, 6 Nov 2021 09:30:33 +0100 (CET) Received: from localhost ([::1]:57078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjH5r-0001Bs-O0 for larch@yhetil.org; Sat, 06 Nov 2021 04:30:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjH5O-0001Aj-Qo for bug-guix@gnu.org; Sat, 06 Nov 2021 04:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36765) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjH5O-0000zn-Hu for bug-guix@gnu.org; Sat, 06 Nov 2021 04:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjH5O-00071f-9p for bug-guix@gnu.org; Sat, 06 Nov 2021 04:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#51559: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64. References: In-Reply-To: Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 06 Nov 2021 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51559 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 51559@debbugs.gnu.org Received: via spool by 51559-submit@debbugs.gnu.org id=B51559.163618735926931 (code B ref 51559); Sat, 06 Nov 2021 08:30:02 +0000 Received: (at 51559) by debbugs.gnu.org; 6 Nov 2021 08:29:19 +0000 Received: from localhost ([127.0.0.1]:48311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjH4g-00070J-UI for submit@debbugs.gnu.org; Sat, 06 Nov 2021 04:29:19 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:42502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjH4d-000702-60 for 51559@debbugs.gnu.org; Sat, 06 Nov 2021 04:29:17 -0400 Received: by mail-wm1-f67.google.com with SMTP id d72-20020a1c1d4b000000b00331140f3dc8so8016025wmd.1 for <51559@debbugs.gnu.org>; Sat, 06 Nov 2021 01:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:subject:mime-version:to:cc:content-transfer-encoding :message-id; bh=5GcquIbkWscwtrCLR7Pzxi88M2ts4oT+5wBk57PK98E=; b=i4hUFBOVEbfLJESzYpPnIDcMCI9M3nZD71JbLiUQMavuyh3SuAZJUFZxh3F+IHGlS+ FoysIxCdxPWzOqtOTdfVXLQZyikmOGLJg18fmrXAjtnxFiOtELzS640T9VIaTrF82ZXY 5doQku7AQvfq8n0e0EyjLBtOYhTRRxzYWkMDs+MP3aeCs2/U/SYX3sQn0kAV0SJlx/G8 Qj5EO5HfJSDQq2oEpCuAzqRDazV4FuzKpi828ij6AqROdkPYGmoif51YmoD4pGhMf6D+ b+TbbeyR9QJ2pGT/Jv2D1S1zCvQ7yf6yMwLYM9KSHX7s+qEkldaTEdMoP+cCIGHjrIX7 /lnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:subject:mime-version:to:cc :content-transfer-encoding:message-id; bh=5GcquIbkWscwtrCLR7Pzxi88M2ts4oT+5wBk57PK98E=; b=YNJQBhjqydNBMXfswIJO8vNSHGZfCeh8DXKZUShgBfX5vb6qrE9ycOmIyG1d16a6hJ U8A7sWtMMN3EVNrZZXJfEUssCfQ1q2CbfMZ9WsR0wNeWBXlWz0WGPc8Jo+j1h1ApvVRL PHNywJh9WTjG8PBXS24V6bqszAnOVHBTnE2eEZQgFcvGF99+FYUMw9WoLahEy70NgZRZ gwXuBcUGQGtvK6b1Dg4A3qZqBguJBfW63UQgRFo/eV2AznUQGS2HR+N0OtsBwHIsykuG y8C9DMZH+UqkIF0wl9evLEF4tW4G184Tev6EQoHV0HjvWER0fpl+VfAvJGrCO0yZ3btP qwbw== X-Gm-Message-State: AOAM533WbQHATXcXoH/VvhnyTazGatKc0SXcrUxhPcpp40iRtt4Y4lPr 5PnowjWFX/ofHLtr6Nn61brzej0hep0y+g== X-Google-Smtp-Source: ABdhPJxchElo3ooBh/wvaUqcIiNIVgDzh/T+7f+6vb4xK1Ssb0bQC8Dmd/CioQ3+qza3yOzVsAd/6g== X-Received: by 2002:a05:600c:3584:: with SMTP id p4mr19708841wmq.109.1636187349092; Sat, 06 Nov 2021 01:29:09 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g2sm9761230wrq.62.2021.11.06.01.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Nov 2021 01:29:08 -0700 (PDT) From: Liliana Marie Prikler Date: Sat, 6 Nov 2021 09:21:02 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID: <5a2e4473e11fef78539f75a86f4cda9c105c44be.camel@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maxim.cournoyer@gmail.com Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636187433; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5GcquIbkWscwtrCLR7Pzxi88M2ts4oT+5wBk57PK98E=; b=bdOCjIGIQeZUJ28RY/xDXnTCwmVDaOXV7oR495attucQKTCLyyCXYbFn3x27psg44bcwp9 UQ77j+3gI0FpDcnqFZRNOigDqXs+LFzBXcoKBbjukyS/2wtyLt8cqd6OiG7lcRPzMlnIdY WrtaYQUaQwPs6JSsq7d37ugMTQnJPdPEa+E9979q5C5b8OoBZcV1bFFemt7xt2Xt7QdVrF IaYKRN46rLY/BYqZ2V3atc6YhKz/dj93xi60SVlm8PbkJicTn5eof5OI6E9RN6LSKhZBRw eJkr9WGLhg8SRaLAD3GpMgzPMXXi+4QrO/5y9DKpcqU4uCkO0rJ9pxp3gnTkIw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636187433; a=rsa-sha256; cv=none; b=KCM9uCj/TSdzRQSi9b+E8JOQukggoLq8P1x6p3SUMAz1y6FXAQu30Oikk1wScfMmPObJAO Vap7tUgUs9JZDaBaXOs+0GPsIxXcYDXRBWb9tByEAgWSdnxvTX6EUU86oaF8XyvhWLnDw4 cGm5G3eFwi0oAlgwWVki/Npn046aCTr97bc26eGtvLEt9r7K0BJw06xpnFONxoVvGW1pSb m+CyKCd1cK0Qcg7PKtCsjktv7FByr59j4ufQcBZ2jppTXnnr6MYWBcdB5I29AJTrz+DiCH ycz75k+mtC3CL2TUAq5LC2PqY3in0L7eigEqzFyAZ2EMopHfnHI9c36KaxTA4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=i4hUFBOV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=i4hUFBOV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 1A4192C32C X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: K8IfWi/uM42f * gnu/packages/webkit.scm (webkitgtk)[#:phases]: Add ‘disable-sse2’ if the current (target) system is not an x86_64 one. --- Hi Maxime, I tried conditionally disabling SSE2 on the host side, but for some reason this patch would cause a rebuild for me. Did I do something wrong? gnu/packages/webkit.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm index e54b680855..ca50ab37a8 100644 --- a/gnu/packages/webkit.scm +++ b/gnu/packages/webkit.scm @@ -241,7 +241,7 @@ (define-public webkitgtk (build-system cmake-build-system) (outputs '("out" "doc")) (arguments - '(#:tests? #f ; no tests + `(#:tests? #f ; no tests #:build-type "Release" ; turn off debugging symbols to save space #:configure-flags (list "-DPORT=GTK" @@ -295,6 +295,13 @@ (define-public webkitgtk (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version) (string-append wpebackend-fdo "/lib/" all))) #t))) + ,@(if (string-prefix? "x68_64" (or (%current-target-system) + (%current-system))) + '() + '((add-after 'unpack 'disable-sse2 + (lambda _ + (substitute* "Source/cmake/DetectSSE2.cmake" + (("CHECK_FOR_SSE2\\(\\)") "")))))) (add-before 'configure 'prepare-build-environment (lambda* (#:key inputs #:allow-other-keys) (setenv "CC" "clang") -- 2.33.1