* bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog. [not found] <8351ca4e6f107a0f20b0441507ecb6ab7aa30856.1538225757.git.leo@famulari.name> @ 2018-09-29 22:05 ` Ludovic Courtès 2018-09-30 11:42 ` Leo Famulari 0 siblings, 1 reply; 3+ messages in thread From: Ludovic Courtès @ 2018-09-29 22:05 UTC (permalink / raw) To: Leo Famulari; +Cc: 32872, 30642 Hi! Leo Famulari <leo@famulari.name> skribis: > Without this, LibreOffice crashes on a foreign distro when the "file > open" dialog is launched. I think there *must* be a better solution but > until we identify it, we should fix the crash. I'm Currently building > this to test it. > > * gnu/packages/libreoffice.scm (libreoffice)[arguments]: Add 'wrap-program' > phase. You could mention <https://bugs.gnu.org/30642> in the log. One option discussed at the time was to use ‘glib-or-gtk-build-system’, which should have an effect similar to the patch you posted. Perhaps we should just do that? > + (add-after 'bin-and-desktop-install 'wrap-programs > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) Nitpick: the lambda’s body is too indented. :-) Thank you! Ludo’. ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog. 2018-09-29 22:05 ` bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog Ludovic Courtès @ 2018-09-30 11:42 ` Leo Famulari 2018-12-04 21:29 ` Ludovic Courtès 0 siblings, 1 reply; 3+ messages in thread From: Leo Famulari @ 2018-09-30 11:42 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 32872, 30642 [-- Attachment #1: Type: text/plain, Size: 715 bytes --] On Sun, Sep 30, 2018 at 12:05:56AM +0200, Ludovic Courtès wrote: > You could mention <https://bugs.gnu.org/30642> in the log. Right, thanks. > One option discussed at the time was to use ‘glib-or-gtk-build-system’, > which should have an effect similar to the patch you posted. Perhaps we > should just do that? I tried this, and the build crashed in the bin-and-desktop-install-phase. I'm currently rebuilding with --keep-failed to learn more, but it takes several hours on my fastest computer. Could I try building it on Bayfront to speed up the iteration time? > Nitpick: the lambda’s body is too indented. :-) It turned out to be completely malformed, but I've fixed it locally. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog. 2018-09-30 11:42 ` Leo Famulari @ 2018-12-04 21:29 ` Ludovic Courtès 0 siblings, 0 replies; 3+ messages in thread From: Ludovic Courtès @ 2018-12-04 21:29 UTC (permalink / raw) To: Leo Famulari; +Cc: 32872-done, 30642-done Leo Famulari <leo@famulari.name> skribis: > On Sun, Sep 30, 2018 at 12:05:56AM +0200, Ludovic Courtès wrote: >> You could mention <https://bugs.gnu.org/30642> in the log. > > Right, thanks. This fix was pushed in 994bccd9443032141accede0e403cbfb62f6c63e, closing! Ludo’. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-04 21:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <8351ca4e6f107a0f20b0441507ecb6ab7aa30856.1538225757.git.leo@famulari.name>
2018-09-29 22:05 ` bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog Ludovic Courtès
2018-09-30 11:42 ` Leo Famulari
2018-12-04 21:29 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).