From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix
	GtkFileChooserDialog.
Date: Sun, 30 Sep 2018 00:05:56 +0200
Message-ID: <877ej4vu0r.fsf@gnu.org>
References: <8351ca4e6f107a0f20b0441507ecb6ab7aa30856.1538225757.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53118)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g6NOE-0005z0-33
	for bug-guix@gnu.org; Sat, 29 Sep 2018 18:07:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g6NOA-0003up-Ev
	for bug-guix@gnu.org; Sat, 29 Sep 2018 18:07:04 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:54987)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1g6NOA-0003ua-5V
	for bug-guix@gnu.org; Sat, 29 Sep 2018 18:07:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g6NO9-0002lm-Vv
	for bug-guix@gnu.org; Sat, 29 Sep 2018 18:07:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.30642.B30642.153825876610560@debbugs.gnu.org>
In-Reply-To: <8351ca4e6f107a0f20b0441507ecb6ab7aa30856.1538225757.git.leo@famulari.name>
	(Leo Famulari's message of "Sat, 29 Sep 2018 08:56:50 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 32872@debbugs.gnu.org, 30642@debbugs.gnu.org

Hi!

Leo Famulari <leo@famulari.name> skribis:

> Without this, LibreOffice crashes on a foreign distro when the "file
> open" dialog is launched. I think there *must* be a better solution but
> until we identify it, we should fix the crash. I'm Currently building
> this to test it.
>
> * gnu/packages/libreoffice.scm (libreoffice)[arguments]: Add 'wrap-progra=
m'
> phase.

You could mention <https://bugs.gnu.org/30642> in the log.

One option discussed at the time was to use =E2=80=98glib-or-gtk-build-syst=
em=E2=80=99,
which should have an effect similar to the patch you posted.  Perhaps we
should just do that?

> +           (add-after 'bin-and-desktop-install 'wrap-programs
> +             (lambda* (#:key inputs outputs #:allow-other-keys)
> +                      (let* ((out (assoc-ref outputs "out"))

Nitpick: the lambda=E2=80=99s body is too indented.  :-)

Thank you!

Ludo=E2=80=99.