* Re: A bug, I think, in the process of compiling Guile 3.0.2 on NetBSD 9
2020-05-26 3:02 A bug, I think, in the process of compiling Guile 3.0.2 on NetBSD 9 Jay Sulzberger
@ 2020-05-26 6:47 ` Jay Sulzberger
0 siblings, 0 replies; 2+ messages in thread
From: Jay Sulzberger @ 2020-05-26 6:47 UTC (permalink / raw)
To: Guile User
On Mon, 25 May 2020, Jay Sulzberger wrote:
> There is an old bug report at
>
> https://lists.gnu.org/archive/html/bug-guile/2016-07/msg00038.html
>
> I believe I ran into this same bug on my way to compiling Guile-3.0.2 on NetBSD 9.
>
> After my signature is the report, as rendered by lynx.
>
> Heaven forwarding I will submit a proper bug report within a few
> weeks, after I learn more about the build process of Guile-3.0.2. But
> I ask here: Has this bug been fixed in either Guile-3.0.2 and/or
> NetBSD 9?
>
> Thank you for reading this!
>
> And thank you for Guile!
>
> I remain, as ever, your old beGuiled user^W^WLisper,
> Jay Sulzberger
Ah, perhaps there is a patch for this bug, which bug is, seemingly, due
to an interaction between NetBSD and the guile-3-0-2 tarball.
The patch is offered at
https://lists.gnu.org/archive/html/emacs-diffs/2016-09/msg00144.html
Below my signature is the post, by Paul Eggert, about the patch.
And below that is, again, the original post, by Thomas Klausner, about the bug.
oo--JS.
---------- Forwarded message ----------
Subject: [Emacs-diffs] master c060396: Port recent flexmember changes to NetBSD
X-URL: https://lists.gnu.org/archive/html/emacs-diffs/2016-09/msg00144.html
emacs-diffs
[Top][All Lists]
______________________________ Search Advanced
______________________________________________________________________________________________
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master c060396: Port recent flexmember changes to NetBSD
______________________________________________________________________________________________
From: Paul Eggert
Subject: [Emacs-diffs] master c060396: Port recent flexmember changes to NetBSD
Date: Wed, 21 Sep 2016 22:18:09 +0000 (UTC)
______________________________________________________________________________________________
branch: master
commit c0603964fdaac5209c65bb4af061cbc74747fdb5
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>
Port recent flexmember changes to NetBSD
The NetBSD library supports localtime_rz directly, and without
this change 'configure' omitted the flexmember test that is marked
as conditional on localtime_rz. Emacs now needs to use
flexmember.m4 even when localtime_rz works.
Problem reported by Thomas Klausner.
* admin/merge-gnulib (GNULIB_MODULES): Add flexmember.
* lib/gnulib.mk, m4/gnulib-comp.m4: Regenerate.
---
admin/merge-gnulib | 3 ++-
lib/gnulib.mk | 4 +---
m4/gnulib-comp.m4 | 13 +------------
3 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/admin/merge-gnulib b/admin/merge-gnulib
index ada80b4..29e5e43 100755
--- a/admin/merge-gnulib
+++ b/admin/merge-gnulib
@@ -30,7 +30,8 @@ GNULIB_MODULES='
careadlinkat close-stream count-one-bits count-trailing-zeros
crypto/md5 crypto/sha1 crypto/sha256 crypto/sha512
dtoastr dtotimespec dup2 environ execinfo faccessat
- fcntl fcntl-h fdatasync fdopendir filemode filevercmp fstatat fsync
+ fcntl fcntl-h fdatasync fdopendir
+ filemode filevercmp flexmember fstatat fsync
getloadavg getopt-gnu gettime gettimeofday gitlog-to-changelog
ignore-value intprops largefile lstat
manywarnings memrchr mkostemp mktime
diff --git a/lib/gnulib.mk b/lib/gnulib.mk
index e11e0ca..a691a0b 100644
--- a/lib/gnulib.mk
+++ b/lib/gnulib.mk
@@ -21,7 +21,7 @@
# the same distribution terms as the rest of that program.
#
# Generated by gnulib-tool.
-# Reproduce by: gnulib-tool --import --lib=libgnu --source-base=lib
--m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux
--avoid=close --avoid=dup --avoid=fchdir --avoid=fstat --avoid=malloc-posix
--avoid=msvc-inval --avoid=msvc-nothrow --avoid=open --avoid=openat-die
--avoid=opendir --avoid=raise --avoid=save-cwd --avoid=select --avoid=setenv
--avoid=sigprocmask --avoid=stdarg --avoid=stdbool --avoid=threadlib
--avoid=unsetenv --makefile-name=gnulib.mk --conditional-depend [...]
+# Reproduce by: gnulib-tool --import --lib=libgnu --source-base=lib
--m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux
--avoid=close --avoid=dup --avoid=fchdir --avoid=fstat --avoid=malloc-posix
--avoid=msvc-inval --avoid=msvc-nothrow --avoid=open --avoid=openat-die
--avoid=opendir --avoid=raise --avoid=save-cwd --avoid=select --avoid=setenv
--avoid=sigprocmask --avoid=stdarg --avoid=stdbool --avoid=threadlib
--avoid=unsetenv --makefile-name=gnulib.mk --conditional-depend [...]
MOSTLYCLEANFILES += core *.stackdump
@@ -451,9 +451,7 @@ EXTRA_DIST += filevercmp.h
## begin gnulib module flexmember
-if gl_GNULIB_ENABLED_flexmember
-endif
EXTRA_DIST += flexmember.h
## end gnulib module flexmember
diff --git a/m4/gnulib-comp.m4 b/m4/gnulib-comp.m4
index 5a660c5..592543b 100644
--- a/m4/gnulib-comp.m4
+++ b/m4/gnulib-comp.m4
@@ -234,6 +234,7 @@ AC_DEFUN([gl_INIT],
gl_DIRENT_MODULE_INDICATOR([fdopendir])
gl_MODULE_INDICATOR([fdopendir])
gl_FILEMODE
+ AC_C_FLEXIBLE_ARRAY_MEMBER
gl_FUNC_FPENDING
if test $gl_cv_func___fpending = no; then
AC_LIBOBJ([fpending])
@@ -416,7 +417,6 @@ AC_DEFUN([gl_INIT],
gl_gnulib_enabled_dirfd=false
gl_gnulib_enabled_dosname=false
gl_gnulib_enabled_euidaccess=false
- gl_gnulib_enabled_flexmember=false
gl_gnulib_enabled_getdtablesize=false
gl_gnulib_enabled_getgroups=false
gl_gnulib_enabled_be453cec5eecf5731a274f2de7f2db36=false
@@ -476,13 +476,6 @@ AC_DEFUN([gl_INIT],
fi
fi
}
- func_gl_gnulib_m4code_flexmember ()
- {
- if ! $gl_gnulib_enabled_flexmember; then
- AC_C_FLEXIBLE_ARRAY_MEMBER
- gl_gnulib_enabled_flexmember=true
- fi
- }
func_gl_gnulib_m4code_getdtablesize ()
{
if ! $gl_gnulib_enabled_getdtablesize; then
@@ -690,9 +683,6 @@ AC_DEFUN([gl_INIT],
if { test $HAVE_DECL_STRTOUMAX = 0 || test $REPLACE_STRTOUMAX = 1; } && test
$ac_cv_type_unsigned_long_long_int = yes; then
func_gl_gnulib_m4code_strtoull
fi
- if test "$HAVE_TIMEZONE_T" = 0; then
- func_gl_gnulib_m4code_flexmember
- fi
if test $HAVE_TIMEGM = 0 || test $REPLACE_TIMEGM = 1; then
func_gl_gnulib_m4code_5264294aa0a5557541b53c8c741f7f31
fi
@@ -701,7 +691,6 @@ AC_DEFUN([gl_INIT],
AM_CONDITIONAL([gl_GNULIB_ENABLED_dirfd], [$gl_gnulib_enabled_dirfd])
AM_CONDITIONAL([gl_GNULIB_ENABLED_dosname], [$gl_gnulib_enabled_dosname])
AM_CONDITIONAL([gl_GNULIB_ENABLED_euidaccess],
[$gl_gnulib_enabled_euidaccess])
- AM_CONDITIONAL([gl_GNULIB_ENABLED_flexmember],
[$gl_gnulib_enabled_flexmember])
AM_CONDITIONAL([gl_GNULIB_ENABLED_getdtablesize],
[$gl_gnulib_enabled_getdtablesize])
AM_CONDITIONAL([gl_GNULIB_ENABLED_getgroups], [$gl_gnulib_enabled_getgroups])
AM_CONDITIONAL([gl_GNULIB_ENABLED_be453cec5eecf5731a274f2de7f2db36],
[$gl_gnulib_enabled_be453cec5eecf5731a274f2de7f2db36])
______________________________________________________________________________________________
reply via email to
Paul Eggert
______________________________________________________________________________________________
[Prev in Thread] Current Thread [Next in Thread]
* [Emacs-diffs] master c060396: Port recent flexmember changes to NetBSD, Paul Eggert <=
______________________________________________________________________________________________
* Prev by Date: [Emacs-diffs] master c056077: * doc/misc/texinfo.tex: Copy from gnulib.
* Next by Date: [Emacs-diffs] master 0b6d805: * lisp/progmodes/cc-engine.el
(c-forward-decl-or-cast-1): Fix coding error
* Previous by thread: [Emacs-diffs] master c056077: * doc/misc/texinfo.tex: Copy from gnulib.
* Next by thread: [Emacs-diffs] master 0b6d805: * lisp/progmodes/cc-engine.el
(c-forward-decl-or-cast-1): Fix coding error
* Index(es):
+ Date
+ Thread
---------- End Forwarded message ----------
>
>
> ---------- Forwarded message ----------
> Subject: bug#24002: configure: missing call to AC_C_FLEXIBLE_ARRAY_MEMBER
> X-URL: https://lists.gnu.org/archive/html/bug-guile/2016-07/msg00038.html
>
> bug-guile
>
> [Top][All Lists]
>
> ______________________________ Search Advanced
> ______________________________________________________________________________________________
>
> [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
>
> bug#24002: configure: missing call to AC_C_FLEXIBLE_ARRAY_MEMBER
> ______________________________________________________________________________________________
>
> From: Thomas Klausner
> Subject: bug#24002: configure: missing call to AC_C_FLEXIBLE_ARRAY_MEMBER
> Date: Sat, 16 Jul 2016 11:13:04 +0200
> ______________________________________________________________________________________________
>
> Hi!
>
> On NetBSD, the build of guile-2.0.12 breaks early because
> FLEXIBLE_ARRAY_MEMBER is not defined:
>
> In file included from strftime.c:33:0:
> time-internal.h:48:14: error: 'FLEXIBLE_ARRAY_MEMBER' undeclared here (not in a
> function)
> char abbrs[FLEXIBLE_ARRAY_MEMBER];
> ^
>
> config.h has:
>
> /* #undef FLEXIBLE_ARRAY_MEMBER */
>
> I think the problem is that m4/gnulib-comp.m4 has:
>
> if test "$HAVE_TIMEZONE_T" = 0; then
> func_gl_gnulib_m4code_flexmember
> fi
>
> but on NetBSD, HAVE_TIMEZONE_T is 1 and so
> func_gl_gnulib_m4code_flexmember is not called and
> FLEXIBLE_ARRAY_MEMBER is not defined.
>
> FLEXIBLE_ARRAY_MEMBER is used in time-internal.h which is included by:
>
> lib/time_rz.c lib/timegm.c lib/strftime.c lib/mktime.c
>
> so there might be more cases where this will break.
>
> Cheers,
> Thomas
>
>
>
>
> ______________________________________________________________________________________________
>
> reply via email to
> Thomas Klausner
> ______________________________________________________________________________________________
>
> [Prev in Thread] Current Thread [Next in Thread]
>
> * bug#24002: configure: missing call to AC_C_FLEXIBLE_ARRAY_MEMBER, Thomas Klausner <=
> ______________________________________________________________________________________________
>
> * Prev by Date: bug#20339: sxml simple: sxml->xml mishandles namespaces?
> * Next by Date: bug#24003: guile-2.0.12: test failure on NetBSD: test-loose-ends
> * Previous by thread: bug#23974: Outdated instructions regarding bdw-gc in guile 2.0.11
> * Next by thread: bug#24003: guile-2.0.12: test failure on NetBSD: test-loose-ends
> * Index(es):
> + Date
> + Thread
>
> ---------- End Forwarded message ----------
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread