unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Jean Abou Samra <jean@abou-samra.fr>
To: Jonas Hahnfeld <hahnjo@hahnjo.de>, Andy Wingo <wingo@pobox.com>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Fixes for custom-ports
Date: Tue, 28 Nov 2023 22:11:30 +0100	[thread overview]
Message-ID: <d40701e38c33a502f3e61ec78555751ef2011041.camel@abou-samra.fr> (raw)
In-Reply-To: <441968d3aa118c66ddc376f66cc73bfcbf9578c4.camel@hahnjo.de>


[-- Attachment #1.1: Type: text/plain, Size: 575 bytes --]

Le dimanche 29 octobre 2023 à 10:51 +0100, Jonas Hahnfeld via Developers list
for Guile, the GNU extensibility library a écrit :
> while playing with current Guile main on Windows, I found some problems
> in the implementation of custom-ports that was recently committed.
> Please consider the attached patches.


Not a Guile maintainer obviously, but: could you explain what the first patch is
for? It's not going to hurt, but I don't see what problem it fixes.

Second patch looks like a no-brainer that any committer passing by could
apply...

Jean




[-- Attachment #1.2: Type: text/html, Size: 1240 bytes --]

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2023-11-28 21:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-29  9:51 [PATCH] Fixes for custom-ports Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2023-11-28 21:01 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-01-04 10:36   ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2023-11-28 21:11 ` Jean Abou Samra [this message]
2023-11-29  6:47   ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2023-11-29  6:54     ` Jean Abou Samra
2023-11-29  7:26       ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-01-29 13:46 ` Ludovic Courtès
2024-01-29 21:34   ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-02-09  4:47   ` Maxim Cournoyer
2024-02-10 10:08     ` Ludovic Courtès
2024-02-11 16:41       ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d40701e38c33a502f3e61ec78555751ef2011041.camel@abou-samra.fr \
    --to=jean@abou-samra.fr \
    --cc=guile-devel@gnu.org \
    --cc=hahnjo@hahnjo.de \
    --cc=wingo@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).