From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Abou Samra Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Fixes for custom-ports Date: Tue, 28 Nov 2023 22:11:30 +0100 Message-ID: References: <441968d3aa118c66ddc376f66cc73bfcbf9578c4.camel@hahnjo.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-/sXAo2xSzpInmGRpHT5U" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19853"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) Cc: guile-devel@gnu.org To: Jonas Hahnfeld , Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Tue Nov 28 22:12:14 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r85NN-00051H-Ag for guile-devel@m.gmane-mx.org; Tue, 28 Nov 2023 22:12:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r85Mv-00030a-4L; Tue, 28 Nov 2023 16:11:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r85Mt-00030M-BK for guile-devel@gnu.org; Tue, 28 Nov 2023 16:11:43 -0500 Original-Received: from mout.kundenserver.de ([212.227.17.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r85Mr-0003rh-D9 for guile-devel@gnu.org; Tue, 28 Nov 2023 16:11:43 -0500 Original-Received: from [192.168.1.12] ([83.202.85.244]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MvsMz-1rON1w2Ugp-00ssju; Tue, 28 Nov 2023 22:11:31 +0100 In-Reply-To: <441968d3aa118c66ddc376f66cc73bfcbf9578c4.camel@hahnjo.de> Autocrypt: addr=jean@abou-samra.fr; prefer-encrypt=mutual; keydata=mDMEYz8qHRYJKwYBBAHaRw8BAQdAKa699V3Pc3AOAg40hnai7Ljs1uAOxkeopSA7uz+TN/q0JEplYW4gQWJvdSBTYW1yYSA8amVhbkBhYm91LXNhbXJhLmZyPoiTBBMWCgA7FiEEme0ysZyhsgbwY8wZo/D2C4kzl/4FAmM/Kh0CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQo/D2C4kzl/5MjQEAzHgLjZqtPK4nM5d4a+c03tUmYTKsGnfiHYPbSwD7V2cA/1kL/iF8C8wN/K//1+8vRd4iuv1jrPbpLv11LHWg+EkMuDgEYz8qHRIKKwYBBAGXVQEFAQEHQH0iBXUPzOJuyB2BtsqYTFqM4MLa6EuVsLfeIWGHqFQIAwEIB4h4BBgWCgAgFiEEme0ysZyhsgbwY8wZo/D2C4kzl/4FAmM/Kh0CGwwACgkQo/D2C4kzl/6AtAEAvKhPZXuZ3WuuantJJ3VBeknOn0oPSqt24zFFseobJ3IA/jGs23lNR8StTl5KMvvqSLfSCWr1wO8xFkneQbwWliIF X-Provags-ID: V03:K1:45Uk+YYz10nrwbwUFU2j1OaxvDRes6bsDV6e7WwMzycmrDmWfjq Zcro5AK6IKCbbFAUSNER4iRmbj8acov3Uihe+baEsvWQL+FxbJime5VwWzMnJioQtJItAQi kZEywCJC7ZhhEXYyI3FYmnaivpGBgbNnorzEzwWR0DmK3ftU1qUOyhF9Fn6Uv+QD2idCg2c hoF/fydSfo2ZqKE5+3yEQ== UI-OutboundReport: notjunk:1;M01:P0:Fca6GfkfEqU=;HlUQl9nqprtmc57I8bL74MlNfyw KsOiJObf4J7uBiASIARJb1InzoYHV8NT/UNi86hc95NIxth1qFt5xud2gPb8GiKFi3iG5cqsu rLZsemLJWEuE6kp2T/i5CsGlxBzuDqA/Q4gix6DyVweSUG4haLLWr2QLJIxVEikGUKGvImfR7 S8t77/HMVViCAEWKjh/dEuIRMKd8GcV0dTXOnbIHTypOIkaZDdzz4jMSslLREiUvnd8vfiVi4 8gTRFVJ0ZZq5HerpisjfOtHIEujMQwPTgcQr9Kd8EfN/oqetpKvUhR2kOze3jwPgF+zNXdLsp fKQTYIazh1YxUv/fhTfYh01DZh7spI168/q3qntx/zS5UZkrJFzzezkguq/gsdF0yAC/j+uk/ KZ8goVinqnVyAEBRiELrnVWdv6W+R71h/kDIG5o8uvNHTyX1Au2+8htG8XkQf38pZVM//dvAn yW1o11pWc9TQp1y9dBXivP4vV/i4mojKolOGr6fVoFOk0Sb2t9tJ++f0JG3cjw/SVX06k1By4 cNsYheA4CNcDJx4fdvz/SaRi8SSEe4GEPrfv1iJAA1IyfzhOM0ZV87vKPLnoQ1tc42ELGsDUN 5rdR/nlLsUI8/jvSRM4wjlgwCX5DatA16r2j609T4PK2zJscZaFz/JUzFonNg5AmAwEyqaXYU WsMjv3ZxrLAgOom1bQUivake7Z06zl+hK+tmRn+yma0dQbylKG128ARdgOvuV0zYg4ngavnhk weX4m287EZqrz9PRfPVLr2q0SkFRg7MPfV5UGd8uuZz8AcszVjmW2A4iwp1d2QYLkoQ7w7Fn Received-SPF: pass client-ip=212.227.17.10; envelope-from=jean@abou-samra.fr; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22135 Archived-At: --=-/sXAo2xSzpInmGRpHT5U Content-Type: multipart/alternative; boundary="=-SChJQDB8kqGddPiVS4TL" --=-SChJQDB8kqGddPiVS4TL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le dimanche 29 octobre 2023 =C3=A0 10:51 +0100, Jonas Hahnfeld via Develope= rs list for Guile, the GNU extensibility library a =C3=A9crit=C2=A0: > while playing with current Guile main on Windows, I found some problems > in the implementation of custom-ports that was recently committed. > Please consider the attached patches. Not a Guile maintainer obviously, but: could you explain what the first pat= ch is for? It's not going to hurt, but I don't see what problem it fixes. Second patch looks like a no-brainer that any committer passing by could apply... Jean --=-SChJQDB8kqGddPiVS4TL Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Le dimanche 29 octobre 2023 =C3=A0 10:51 +0100, J= onas Hahnfeld via Developers list for Guile, the GNU extensibility library = a =C3=A9crit :
while playing with= current Guile main on Windows, I found some problems
in the impl= ementation of custom-ports that was recently committed.
Pleas= e consider the attached patches.


=
Not a Guile maintainer obviously, but: could you explain what th= e first patch is for? It's not going to hurt, but I don't see what problem = it fixes.

Second patch looks like a no-brainer tha= t any committer passing by could apply...

Jean


--=-SChJQDB8kqGddPiVS4TL-- --=-/sXAo2xSzpInmGRpHT5U Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSZ7TKxnKGyBvBjzBmj8PYLiTOX/gUCZWZXggAKCRCj8PYLiTOX /hNsAQCD5OLh1U9Mpt2Ss3HMrlQ4wWp+DaYQTfOzXu3t7hrOzgD/Y8USznw9BIqk K+Ec3wXdkgryVXxyGO5qMFrvtDFNwQQ= =f2Du -----END PGP SIGNATURE----- --=-/sXAo2xSzpInmGRpHT5U--