From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Jonas Hahnfeld <hahnjo@hahnjo.de>, guile-devel@gnu.org
Subject: Re: [PATCH] Fixes for custom-ports
Date: Thu, 08 Feb 2024 23:47:29 -0500 [thread overview]
Message-ID: <87fry2p7ku.fsf@gmail.com> (raw)
In-Reply-To: <87h6iwp806.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 29 Jan 2024 14:46:33 +0100")
Hi Ludo,
Ludovic Courtès <ludo@gnu.org> writes:
> Jonas Hahnfeld via "Developers list for Guile, the GNU extensibility
> library" <guile-devel@gnu.org> skribis:
>
>> From b5f1013ad969b6e4e35b36dc63798375ffbecda3 Mon Sep 17 00:00:00 2001
>> From: Jonas Hahnfeld <hahnjo@hahnjo.de>
>> Date: Tue, 24 Oct 2023 12:47:21 +0200
>> Subject: [PATCH 1/2] Fix loading of custom-ports extension
>>
>> * module/ice-9/custom-ports.scm: Load extension also in expand and eval.
>
>> From 78c97b8a49ba336516e954c6c62e4baa7f429f47 Mon Sep 17 00:00:00 2001
>> From: Jonas Hahnfeld <hahnjo@hahnjo.de>
>> Date: Tue, 24 Oct 2023 19:24:22 +0200
>> Subject: [PATCH 2/2] Match on correct argument in make-custom-port
>>
>> * module/ice-9/custom-ports.scm (make-custom-port): Match on correct
>> argument for conversion strategy.
>
> Applied both, thanks!
>
> Ludo'.
>
> PS: As far as I’m concerned, patches sent to bug-guile@gnu.org are less
> likely to be lost because I see them in M-x debbugs.
>
The contributing documentation mention to send patches to
guile-devel at gnu dot org; should this guidance be changed?
From the HACKING file:
--8<---------------cut here---------------start------------->8---
- If you have put together a change that meets the coding standards
described below, we encourage you to submit it to Guile. Post your
patch to guile-devel@gnu.org.
--8<---------------cut here---------------end--------------->8---
--
Thanks,
Maxim
next prev parent reply other threads:[~2024-02-09 4:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 9:51 [PATCH] Fixes for custom-ports Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2023-11-28 21:01 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-01-04 10:36 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2023-11-28 21:11 ` Jean Abou Samra
2023-11-29 6:47 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2023-11-29 6:54 ` Jean Abou Samra
2023-11-29 7:26 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-01-29 13:46 ` Ludovic Courtès
2024-01-29 21:34 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-02-09 4:47 ` Maxim Cournoyer [this message]
2024-02-10 10:08 ` Ludovic Courtès
2024-02-11 16:41 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fry2p7ku.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guile-devel@gnu.org \
--cc=hahnjo@hahnjo.de \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).