unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>
To: Blake Shaw <blake@sweatshoppe.org>
Cc: Maxime Devos <maximedevos@telenet.be>, guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH v1 1/6] docs/match: add pattern matching examples
Date: Mon, 30 Jan 2023 11:56:15 -0800	[thread overview]
Message-ID: <CA+XASoXvOh9gD-AfHapMdFAEv-RR=_Eff7Yp6bXiz6Grui12xA@mail.gmail.com> (raw)
In-Reply-To: <CAKjmbcAdJ6XXuvrY3K7N78uixcmk+drmNrci7DKXvBMFNNUanA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1656 bytes --]

Hi!

On Sun, Jan 29, 2023 at 4:50 PM Blake Shaw <blake@sweatshoppe.org> wrote:

>
> And there's more, its a pattern; I dont know if you troll everyone like
> this or if I represent something you feel opposed to, but I do know that it
> was enough for me to become allergic to Guile/Guix community until I
> started hanging out on Mastodon and discovered many guix have retreated
> there.
>
>>
>>
First, I apologize for not having gone through all the comments and reviews
or mailing lists messages you guys are discussing. I just wanted to give my
cent (not even two) about the paragraph above.

My interactions with Maxime (mainly through code reviews) have been great.
The biggest review was the one done to merge libevent support into Fibers.
Maxime found the time to review a quite big PR and added a bunch of useful
comments. Reviewing that PR took a lot of effort and I just felt better
after fixing all the comments made. I was even surprised he (I'm assuming
this pronoun) did.

I've always taken code reviews as an opportunity to learn (not suggesting
that you are not, far from that), and whether it's true that Maxime had a
lot of comments (all of them made sense as far as I remember), it's also
true that he is one of the few ones to make code reviews (specially in
Guile). And my feeling is he just wants things to be as correct as
possible, which is quite important, especially in a programming language.

Exchanging messages in a written form has its own challenges (your mood on
that day, maybe you phrase things in a way that can be misunderstood, ...).
So I will stop writing and just leave you all with a smiley face. :-)

Best,

Aleix

[-- Attachment #2: Type: text/html, Size: 3597 bytes --]

  reply	other threads:[~2023-01-30 19:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 18:57 [PATCH v1 1/6] docs/match: add pattern matching examples Blake Shaw
2023-01-26 18:57 ` [PATCH v1 2/6] docs/match: rm unquote-splicing as it interferes with textinfo Blake Shaw
2023-01-27 16:27   ` Maxime Devos
2023-01-28  9:14     ` Blake Shaw
2023-01-28 13:08       ` Maxime Devos
2023-01-29  3:09         ` Blake Shaw
2023-01-26 18:57 ` [PATCH v1 3/6] docs/match: add reverse nested list example Blake Shaw
2023-01-26 18:57 ` [PATCH v1 4/6] docs/match: match-let* unwrap example Blake Shaw
2023-01-26 18:58 ` [PATCH v1 5/6] docs/fixup: @cindex was in the wrong place Blake Shaw
2023-01-26 18:58 ` [PATCH v1 6/6] docs/match:style reviewing with pdf, adding newlines Blake Shaw
2023-01-28 13:18 ` [PATCH v1 1/6] docs/match: add pattern matching examples Maxime Devos
2023-01-28 19:10   ` randomlooser
2023-01-28 19:23     ` randomlooser
     [not found]   ` <CAKjmbcA9TeuC0HWE53cG4EfautTcW5s9tyh0tCXUvicAQiBFKQ@mail.gmail.com>
2023-01-29 14:23     ` Maxime Devos
2023-01-28 13:48 ` Maxime Devos
     [not found]   ` <CAKjmbcAucYA9j7suY1gEAO512pn+90ED33Wq5Z7CjrBsqxgrbw@mail.gmail.com>
2023-01-29 15:30     ` Maxime Devos
2023-01-30  0:49       ` Blake Shaw
2023-01-30 19:56         ` Aleix Conchillo Flaqué [this message]
2023-01-30 19:57           ` Aleix Conchillo Flaqué
2023-01-31  2:53           ` Maxime Devos
2023-01-31  3:59             ` Aleix Conchillo Flaqué
2023-01-31  2:28         ` [PATCH v1 1/6] docs/match: add pattern matching examples + CoC Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+XASoXvOh9gD-AfHapMdFAEv-RR=_Eff7Yp6bXiz6Grui12xA@mail.gmail.com' \
    --to=aconchillo@gmail.com \
    --cc=blake@sweatshoppe.org \
    --cc=guile-devel@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).