Re: [PATCH v1 1/6] docs/match: add pattern matching examples

[randomlooser@riseup.net]

Il giorno sab, 28/01/2023 alle 20.10 +0100, randomlooser@riseup.net ha
scritto:
> Il giorno sab, 28/01/2023 alle 14.18 +0100, Maxime Devos ha scritto:
> > 
> > 
> > > +(define (english-base-ten->number name)
> > > +  (match name
> > > +    ('zero   0)
> > > +    ('one    1)
> > > +    ('two    2)
> > > +    ('three  3)
> > > +    ('four   4)
> > > +    ('five   5)
> > > +    ('six    6)
> > > +    ('seven  7)
> > > +    ('eight  8)
> > > +    ('nine   9)))
> > > +
> > > +(english-base-ten->number 'six)
> > > +@result{} 6
> > 
> > This is a suboptimal example; this would be better done with
> > 'case'.
> > I propose replacing it with another example, or adding a note that
> > one 
> > would normally use 'case' for this.
> 
> The point of this example is not to proficiently program in scheme
> 
> It is to introduce possibly naive people to pattern matching
> effectively
> 
> The aim is to be didactic, there's no implication that this is
> idiomatic scheme
> 
> I'd pay attention at the curse of knowledge that may be at play, here
> 

I just missed the suggestion to add a note

My bad

Adding a note would be perfectly fine