Re: [PATCH] web: authorization header scheme should be capitalized

["Aleix Conchillo Flaqué" <aconchillo@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2506 bytes --]

Sorry, forgot to fix tests in my original email.

This is actually an important bug fix since some servers won't accept
lowercase Authorization header schemes and there's no way around this in
Guile, AFAIK.

Here are a few RFC where they explicitly mention capitalized strings:

"Basic" scheme: https://datatracker.ietf.org/doc/html/rfc7617#section-2
"Bearer" scheme: https://datatracker.ietf.org/doc/html/rfc6750#section-2.1

Aleix

On Thu, Jun 23, 2022 at 1:28 PM Aleix Conchillo Flaqué <aconchillo@gmail.com>
wrote:

> * module/web/http.scm (write-credentials): capitalize authorization
> header scheme. See, for example,
> https://datatracker.ietf.org/doc/html/rfc7617#section-2
> ---
>  module/web/http.scm            | 4 ++--
>  test-suite/tests/web-http.test | 7 ++++---
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/module/web/http.scm b/module/web/http.scm
> index 4276e1744..312c28934 100644
> --- a/module/web/http.scm
> +++ b/module/web/http.scm
> @@ -965,10 +965,10 @@ as an ordered alist."
>  (define (write-credentials val port)
>    (match val
>      (('basic . cred)
> -     (put-string port "basic ")
> +     (put-string port "Basic ")
>       (put-string port cred))
>      ((scheme . params)
> -     (put-symbol port scheme)
> +     (put-string port (string-titlecase (symbol->string scheme)))
>       (put-char port #\space)
>       (write-key-value-list params port))))
>
> diff --git a/test-suite/tests/web-http.test
> b/test-suite/tests/web-http.test
> index 63377349c..df25030de 100644
> --- a/test-suite/tests/web-http.test
> +++ b/test-suite/tests/web-http.test
> @@ -336,9 +336,10 @@
>    (pass-if-parse authorization "Digest foooo" '(digest foooo))
>    (pass-if-parse authorization "Digest foo=bar,baz=qux"
>                   '(digest (foo . "bar") (baz . "qux")))
> -  (pass-if-round-trip "Authorization: basic foooo\r\n")
> -  (pass-if-round-trip "Authorization: digest foooo\r\n")
> -  (pass-if-round-trip "Authorization: digest foo=bar, baz=qux\r\n")
> +  (pass-if-round-trip "Authorization: Basic foooo\r\n")
> +  (pass-if-round-trip "Authorization: Bearer token\r\n")
> +  (pass-if-round-trip "Authorization: Digest foooo\r\n")
> +  (pass-if-round-trip "Authorization: Digest foo=bar, baz=qux\r\n")
>    (pass-if-parse expect "100-continue, foo" '((100-continue) (foo)))
>    (pass-if-parse from "foo@bar" "foo@bar")
>    (pass-if-parse host "qux" '("qux" . #f))
> --
> 2.34.1
>
>

[-- Attachment #2: Type: text/html, Size: 4139 bytes --]