From: Maxime Devos <maximedevos@telenet.be>
To: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>, guile-devel@gnu.org
Subject: Re: [PATCH] web: authorization header scheme should be capitalized
Date: Thu, 23 Jun 2022 22:40:53 +0200 [thread overview]
Message-ID: <922957d6545149287a6aec7b9d258bf2dd7603ef.camel@telenet.be> (raw)
In-Reply-To: <20220623202759.3578506-1-aconchillo@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
Aleix Conchillo Flaqué schreef op do 23-06-2022 om 13:27 [-0700]:
> + (put-string port (string-titlecase (symbol->string scheme)))
I'd add a little explanation in a comment (e.g.:
;; While according to RFC 7617 Schemes are case-insensitive:
;;
;; ‘Note that both scheme and parameter names are matched
;; case-insensitive’
;;
;; some software (*) incorrectly assumes title case for scheme
;; names, so use the more titlecase.
;;
;; (*): See, e.g.,
;; <https://[bug report 1]/>
;; <https://[bug report 2]/>
I think it's reasonable to do some changes in Guile to work-around
potential bugs in other software that Guile has no control over or even
knows about, at the same time Guile seems to be just following the
spec, the compatibility bug seems to be in the other software, so to
help the other software a bit, I think it would be best to report
things in the buggy software too.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-06-23 20:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 20:27 [PATCH] web: authorization header scheme should be capitalized Aleix Conchillo Flaqué
2022-06-23 20:33 ` Aleix Conchillo Flaqué
2022-06-23 20:40 ` Maxime Devos [this message]
2022-06-23 20:42 ` Aleix Conchillo Flaqué
2022-06-23 20:45 ` Maxime Devos
2022-06-23 21:13 ` Aleix Conchillo Flaqué
2022-06-23 22:20 ` Maxime Devos
2022-06-24 1:46 ` Aleix Conchillo Flaqué
2022-06-24 8:35 ` Maxime Devos
2022-06-24 13:41 ` Aleix Conchillo Flaqué
2022-06-24 12:16 ` Dr. Arne Babenhauserheide
-- strict thread matches above, loose matches on Subject: below --
2022-06-23 19:15 Aleix Conchillo Flaqué
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=922957d6545149287a6aec7b9d258bf2dd7603ef.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=aconchillo@gmail.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).