unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Roel Janssen <roel@gnu.org>, guile-devel@gnu.org
Subject: Re: [PATCH] Remove unused variable.
Date: Mon, 24 May 2021 16:19:40 +0200	[thread overview]
Message-ID: <9fe717eed9506a210b62e16a3647c372d1a7ad1f.camel@telenet.be> (raw)
In-Reply-To: <ea9353e4f62e8baed4ceaca8889c3af28cec4603.camel@gnu.org>


[-- Attachment #1.1: Type: text/plain, Size: 418 bytes --]

Roel Janssen schreef op ma 24-05-2021 om 15:01 [+0200]:
> Hi Guilers,
> 
> While compiling Guile with "-Wall" I noticed this unused declaration.

I think you ned to modfy gnulib-local/lib/localcharset.c.diff
as well. It seems like the original localcharset.c comes from gnulib
and it has been patched for Guile. See attached (untested) diff.

LGTM otherwise (/me not Guile maintainer)

Greetings,
Maxime.

[-- Attachment #1.2: a.diff --]
[-- Type: text/x-patch, Size: 433 bytes --]

diff --git a/gnulib-local/lib/localcharset.c.diff b/gnulib-local/lib/localcharset.c.diff
index 04865a345..ec2816622 100644
--- a/gnulib-local/lib/localcharset.c.diff
+++ b/gnulib-local/lib/localcharset.c.diff
@@ -16,7 +16,7 @@ rationale.
 +environ_locale_charset (void)
 +{
 +  static char buf[2 + 10 + 1];
-+  const char *codeset, *aliases;
++  const char *codeset;
 +  const char *locale = NULL;
 +
 +  locale = getenv ("LC_ALL");

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

      reply	other threads:[~2021-05-24 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 13:01 [PATCH] Remove unused variable Roel Janssen
2021-05-24 14:19 ` Maxime Devos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fe717eed9506a210b62e16a3647c372d1a7ad1f.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=guile-devel@gnu.org \
    --cc=roel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).