From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxime Devos Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Remove unused variable. Date: Mon, 24 May 2021 16:19:40 +0200 Message-ID: <9fe717eed9506a210b62e16a3647c372d1a7ad1f.camel@telenet.be> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-i9AdJlf+FoKbMCMy2QZE" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2485"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.34.2 To: Roel Janssen , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Mon May 24 16:31:26 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llBc5-0000Sb-Kg for guile-devel@m.gmane-mx.org; Mon, 24 May 2021 16:31:25 +0200 Original-Received: from localhost ([::1]:50624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llBc4-0003ep-0h for guile-devel@m.gmane-mx.org; Mon, 24 May 2021 10:31:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llBTF-0001Rj-LT for guile-devel@gnu.org; Mon, 24 May 2021 10:22:17 -0400 Original-Received: from albert.telenet-ops.be ([2a02:1800:110:4::f00:1a]:36286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llBTD-0007ey-1e for guile-devel@gnu.org; Mon, 24 May 2021 10:22:17 -0400 Original-Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id 8eNA2500j0mfAB406eNBR2; Mon, 24 May 2021 16:22:11 +0200 In-Reply-To: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1621866131; bh=xxU9HGQEysMWbnD+x2wvcY4/J+kKFqkgQGnxFyk5b1s=; h=Subject:From:To:Date:In-Reply-To:References; b=fCeRLX2SEEo+LavHQOFQALyJ6ONNV2P/lA/19NjOAIq+rlWsncgxQCC2aOdmP93oB nqUJVh8e3+ClplJDEfLTch3bUUuZg+KEFscFXR4dUmThLVhYRyvEN48WBz/Vib05lG 2cS6OCElsIHvpW+OO7XZQmfDhoYwiVHb9Nj/lb0cjKmXwJW45vpgQ9e2HuT+UCP5Sr GtexgoaR/d0KUM+bygY3mFPU8fFdhs5y8g/QYIBJCz79FtQjQZHth/z4mUGN0axiiq FYxDWlTYTytXzVWn7qstIiNvdwEekMSptU6SBkDGDj9GAseKs4IP0iLzo52y4euCKq gjUISWec/C/kg== Received-SPF: pass client-ip=2a02:1800:110:4::f00:1a; envelope-from=maximedevos@telenet.be; helo=albert.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20776 Archived-At: --=-i9AdJlf+FoKbMCMy2QZE Content-Type: multipart/mixed; boundary="=-GCiZXCZlmutGYrP5Bl9t" --=-GCiZXCZlmutGYrP5Bl9t Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Roel Janssen schreef op ma 24-05-2021 om 15:01 [+0200]: > Hi Guilers, >=20 > While compiling Guile with "-Wall" I noticed this unused declaration. I think you ned to modfy gnulib-local/lib/localcharset.c.diff as well. It seems like the original localcharset.c comes from gnulib and it has been patched for Guile. See attached (untested) diff. LGTM otherwise (/me not Guile maintainer) Greetings, Maxime. --=-GCiZXCZlmutGYrP5Bl9t Content-Disposition: attachment; filename="a.diff" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="a.diff"; charset="UTF-8" ZGlmZiAtLWdpdCBhL2dudWxpYi1sb2NhbC9saWIvbG9jYWxjaGFyc2V0LmMuZGlmZiBiL2dudWxp Yi1sb2NhbC9saWIvbG9jYWxjaGFyc2V0LmMuZGlmZgppbmRleCAwNDg2NWEzNDUuLmVjMjgxNjYy MiAxMDA2NDQKLS0tIGEvZ251bGliLWxvY2FsL2xpYi9sb2NhbGNoYXJzZXQuYy5kaWZmCisrKyBi L2dudWxpYi1sb2NhbC9saWIvbG9jYWxjaGFyc2V0LmMuZGlmZgpAQCAtMTYsNyArMTYsNyBAQCBy YXRpb25hbGUuCiArZW52aXJvbl9sb2NhbGVfY2hhcnNldCAodm9pZCkKICt7CiArICBzdGF0aWMg Y2hhciBidWZbMiArIDEwICsgMV07Ci0rICBjb25zdCBjaGFyICpjb2Rlc2V0LCAqYWxpYXNlczsK KysgIGNvbnN0IGNoYXIgKmNvZGVzZXQ7CiArICBjb25zdCBjaGFyICpsb2NhbGUgPSBOVUxMOwog KwogKyAgbG9jYWxlID0gZ2V0ZW52ICgiTENfQUxMIik7Cg== --=-GCiZXCZlmutGYrP5Bl9t-- --=-i9AdJlf+FoKbMCMy2QZE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYKu1/hccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tbdAP9ZGCgNTmSH4n/ewZsVYFFoNfmb Xp+v8Sge7kZgATYKiAEAxrTe41lXv2oacv+Y3QBV04g/gAO1mQOSB1yRSEjnXw4= =3W3H -----END PGP SIGNATURE----- --=-i9AdJlf+FoKbMCMy2QZE--