[-- Attachment #1: Type: text/plain, Size: 111 bytes --] Hi Guilers, While compiling Guile with "-Wall" I noticed this unused declaration. Kind regards, Roel Janssen [-- Attachment #2: 0001-Remove-unused-variable.patch --] [-- Type: text/x-patch, Size: 715 bytes --] From b67638db33e59e026fdbfb6db5468db4f8aebf01 Mon Sep 17 00:00:00 2001 From: Roel Janssen <roel@gnu.org> Date: Mon, 24 May 2021 14:56:20 +0200 Subject: [PATCH] Remove unused variable. * lib/localcharset.c (environ_locale_charset): Remove declaration of 'aliases'. --- lib/localcharset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/localcharset.c b/lib/localcharset.c index 87a5979a3..5d4ce9e05 100644 --- a/lib/localcharset.c +++ b/lib/localcharset.c @@ -1164,7 +1164,7 @@ const char * environ_locale_charset (void) { static char buf[2 + 10 + 1]; - const char *codeset, *aliases; + const char *codeset; const char *locale = NULL; locale = getenv ("LC_ALL"); -- 2.31.1
[-- Attachment #1.1: Type: text/plain, Size: 418 bytes --] Roel Janssen schreef op ma 24-05-2021 om 15:01 [+0200]: > Hi Guilers, > > While compiling Guile with "-Wall" I noticed this unused declaration. I think you ned to modfy gnulib-local/lib/localcharset.c.diff as well. It seems like the original localcharset.c comes from gnulib and it has been patched for Guile. See attached (untested) diff. LGTM otherwise (/me not Guile maintainer) Greetings, Maxime. [-- Attachment #1.2: a.diff --] [-- Type: text/x-patch, Size: 433 bytes --] diff --git a/gnulib-local/lib/localcharset.c.diff b/gnulib-local/lib/localcharset.c.diff index 04865a345..ec2816622 100644 --- a/gnulib-local/lib/localcharset.c.diff +++ b/gnulib-local/lib/localcharset.c.diff @@ -16,7 +16,7 @@ rationale. +environ_locale_charset (void) +{ + static char buf[2 + 10 + 1]; -+ const char *codeset, *aliases; ++ const char *codeset; + const char *locale = NULL; + + locale = getenv ("LC_ALL"); [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 260 bytes --]