Re: [PATCH v4] Add resolve-relative-reference in (web uri), as in RFC 3986 5.2.

[Nathan via "Developers list for Guile, the GNU extensibility library" <guile-devel@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]


The HACKING file says that we always have to go through FSF copyright assignment beforehand, so I was just waiting for that. If they don't care about that anymore, then my name would go in THANKS instead. For completeness, I've attached patches for either case.
(In case I'm still wrong, this would all quickly be sorted out if this patch were to actually be commited.)

I've been using my own fork of the uri.scm library for now that includes many fixes to make it closer to the RFC's specification.
I could contribute those next if this gets merged.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: add me to authors --]
[-- Type: text/x-patch, Size: 1446 bytes --]

From 311cd5759b10537ee4641a48afa9d79e7a6c6055 Mon Sep 17 00:00:00 2001
From: Nathan <nathan_mail@nborghese.com>
Date: Tue, 28 Nov 2023 19:52:57 -0500
Subject: [PATCH 2/2] Add Nathan Borghese to AUTHORS

* AUTHORS: Add Nathan Borghese
* module/web/uri.scm: Update FSF copyright date
---
 AUTHORS            | 6 ++++--
 module/web/uri.scm | 3 +--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/AUTHORS b/AUTHORS
index 2a95d3b0b..10464407b 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -372,9 +372,11 @@ In the subdirectory test-suite/tests, changes to:
     hash.test
 
 Vivien Kraus:
-In the subdirectory module/web, changes to:
-    uri.scm
 In the subdirectory doc/ref, changes to:
     web.texi
 In the subdirectory test-suite/tests, changes to:
     web-uri.test
+
+Nathan Borghese:
+In the subdirectory module/web, changes to:
+    uri.scm
diff --git a/module/web/uri.scm b/module/web/uri.scm
index 2280976b5..9d3063652 100644
--- a/module/web/uri.scm
+++ b/module/web/uri.scm
@@ -1,7 +1,6 @@
 ;;;; (web uri) --- URI manipulation tools
 ;;;;
-;;;; Copyright (C) 1997,2001,2002,2010,2011,2012,2013,2014,2019-2021 Free Software Foundation, Inc.
-;;;; Copyright (C) 2023 Vivien Kraus
+;;;; Copyright (C) 1997,2001,2002,2010,2011,2012,2013,2014,2019-2023 Free Software Foundation, Inc.
 ;;;;
 ;;;; This library is free software; you can redistribute it and/or
 ;;;; modify it under the terms of the GNU Lesser General Public
-- 
2.41.0


[-- Attachment #3: add me to THANKS --]
[-- Type: text/x-patch, Size: 1780 bytes --]

From 7c659b58db0de5f4e229848e177fc47ee0e4bd11 Mon Sep 17 00:00:00 2001
From: Nathan <nathan_mail@nborghese.com>
Date: Tue, 28 Nov 2023 20:10:32 -0500
Subject: [PATCH] Add Nathan Borghese to THANKS

* THANKS: Add Nathan Borghese
* module/web/uri.scm: Add Nathan's copyright
---
 AUTHORS            | 8 --------
 THANKS             | 1 +
 module/web/uri.scm | 2 +-
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/AUTHORS b/AUTHORS
index 2a95d3b0b..d756a74ce 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -370,11 +370,3 @@ John W. Eaton, based on code from AT&T Bell Laboratories and Bellcore:
 Gregory Marton:
 In the subdirectory test-suite/tests, changes to:
     hash.test
-
-Vivien Kraus:
-In the subdirectory module/web, changes to:
-    uri.scm
-In the subdirectory doc/ref, changes to:
-    web.texi
-In the subdirectory test-suite/tests, changes to:
-    web-uri.test
diff --git a/THANKS b/THANKS
index a1f982f04..e986bab20 100644
--- a/THANKS
+++ b/THANKS
@@ -2,6 +2,7 @@ Contributors since the last release:
 
     Christopher Baines
            Greg Benison
+         Nathan Borghese
 	    Rob Browning
         Tristan Colgate-McFarlane
           Aleix Conchillo Flaqué
diff --git a/module/web/uri.scm b/module/web/uri.scm
index 2280976b5..708205136 100644
--- a/module/web/uri.scm
+++ b/module/web/uri.scm
@@ -1,7 +1,7 @@
 ;;;; (web uri) --- URI manipulation tools
 ;;;;
 ;;;; Copyright (C) 1997,2001,2002,2010,2011,2012,2013,2014,2019-2021 Free Software Foundation, Inc.
-;;;; Copyright (C) 2023 Vivien Kraus
+;;;; Copyright (C) 2023 Nathan Borghese
 ;;;;
 ;;;; This library is free software; you can redistribute it and/or
 ;;;; modify it under the terms of the GNU Lesser General Public
-- 
2.41.0


[-- Attachment #4: Type: text/plain, Size: 545 bytes --]



Vivien Kraus <vivien@planete-kraus.eu> writes:

> Le lundi 27 novembre 2023 à 18:10 +0100, Vivien Kraus a écrit :
>> Dear Guile developers,
>> 
>> Some time ago, Nathan wrote this patch as a better version of mine,
>> and
>> I would really like to see it merged.
>> 
>> Does it need more improvement? I consider it pretty good.
>
> Maybe I spoke too soon: the AUTHORS file and the copyright file header
> should not mention me for uri.scm, but Nathan, as this version did not
> retain significant work by me.
>
> Vivien