From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nathan via "Developers list for Guile, the GNU extensibility library" Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH v4] Add resolve-relative-reference in (web uri), as in RFC 3986 5.2. Date: Tue, 28 Nov 2023 20:08:30 -0500 Message-ID: <87r0k9mk7h.fsf@nborghese.com> References: <87fs1n53de.fsf@nborghese.com> <44f50f84a0cb18824d431eb805e2b3963a3776f6.camel@planete-kraus.eu> Reply-To: Nathan Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29286"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: Vivien Kraus Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed Nov 29 02:18:18 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r89DV-0007RB-TW for guile-devel@m.gmane-mx.org; Wed, 29 Nov 2023 02:18:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r89Cz-0000Jt-GJ; Tue, 28 Nov 2023 20:17:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r89Cy-0000JJ-0Y for guile-devel@gnu.org; Tue, 28 Nov 2023 20:17:44 -0500 Original-Received: from mail.nborghese.com ([207.148.28.48]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r89Cw-0004Ki-Az for guile-devel@gnu.org; Tue, 28 Nov 2023 20:17:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=062122; bh=gn5Cfy/aseteF ERdbDYgtqXYar9sAYXJ4ZYqwhf36vQ=; h=in-reply-to:date:subject:cc:to: from:references; d=nborghese.com; b=D5kCrTInxBEUHyFHmhX2SKG/vXm6bdUuQo 9sN0E+DEIAMTyt7iQ78MJIrfayrpuCSaF+HtmGYQ53qRjosOTASZ5f4kzhjf6nbrrSl/rw Zcag5y9apnwDq21oBkVebGGXzqvoJtfdbimQQrkN1AF1vT21OE2vinHNhCiXUiSFPwc= Original-Received: by nborghese.com (OpenSMTPD) with ESMTPSA id d2fce169 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 29 Nov 2023 01:17:33 +0000 (UTC) In-reply-to: Received-SPF: pass client-ip=207.148.28.48; envelope-from=nathan_mail@nborghese.com; helo=mail.nborghese.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22137 Archived-At: --=-=-= Content-Type: text/plain The HACKING file says that we always have to go through FSF copyright assignment beforehand, so I was just waiting for that. If they don't care about that anymore, then my name would go in THANKS instead. For completeness, I've attached patches for either case. (In case I'm still wrong, this would all quickly be sorted out if this patch were to actually be commited.) I've been using my own fork of the uri.scm library for now that includes many fixes to make it closer to the RFC's specification. I could contribute those next if this gets merged. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-Nathan-to-AUTHORS.patch Content-Description: add me to authors >From 311cd5759b10537ee4641a48afa9d79e7a6c6055 Mon Sep 17 00:00:00 2001 From: Nathan Date: Tue, 28 Nov 2023 19:52:57 -0500 Subject: [PATCH 2/2] Add Nathan Borghese to AUTHORS * AUTHORS: Add Nathan Borghese * module/web/uri.scm: Update FSF copyright date --- AUTHORS | 6 ++++-- module/web/uri.scm | 3 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/AUTHORS b/AUTHORS index 2a95d3b0b..10464407b 100644 --- a/AUTHORS +++ b/AUTHORS @@ -372,9 +372,11 @@ In the subdirectory test-suite/tests, changes to: hash.test Vivien Kraus: -In the subdirectory module/web, changes to: - uri.scm In the subdirectory doc/ref, changes to: web.texi In the subdirectory test-suite/tests, changes to: web-uri.test + +Nathan Borghese: +In the subdirectory module/web, changes to: + uri.scm diff --git a/module/web/uri.scm b/module/web/uri.scm index 2280976b5..9d3063652 100644 --- a/module/web/uri.scm +++ b/module/web/uri.scm @@ -1,7 +1,6 @@ ;;;; (web uri) --- URI manipulation tools ;;;; -;;;; Copyright (C) 1997,2001,2002,2010,2011,2012,2013,2014,2019-2021 Free Software Foundation, Inc. -;;;; Copyright (C) 2023 Vivien Kraus +;;;; Copyright (C) 1997,2001,2002,2010,2011,2012,2013,2014,2019-2023 Free Software Foundation, Inc. ;;;; ;;;; This library is free software; you can redistribute it and/or ;;;; modify it under the terms of the GNU Lesser General Public -- 2.41.0 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-Add-Nathan-to-THANKS.patch Content-Transfer-Encoding: quoted-printable Content-Description: add me to THANKS >From 7c659b58db0de5f4e229848e177fc47ee0e4bd11 Mon Sep 17 00:00:00 2001 From: Nathan Date: Tue, 28 Nov 2023 20:10:32 -0500 Subject: [PATCH] Add Nathan Borghese to THANKS * THANKS: Add Nathan Borghese * module/web/uri.scm: Add Nathan's copyright --- AUTHORS | 8 -------- THANKS | 1 + module/web/uri.scm | 2 +- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/AUTHORS b/AUTHORS index 2a95d3b0b..d756a74ce 100644 --- a/AUTHORS +++ b/AUTHORS @@ -370,11 +370,3 @@ John W. Eaton, based on code from AT&T Bell Laboratori= es and Bellcore: Gregory Marton: In the subdirectory test-suite/tests, changes to: hash.test - -Vivien Kraus: -In the subdirectory module/web, changes to: - uri.scm -In the subdirectory doc/ref, changes to: - web.texi -In the subdirectory test-suite/tests, changes to: - web-uri.test diff --git a/THANKS b/THANKS index a1f982f04..e986bab20 100644 --- a/THANKS +++ b/THANKS @@ -2,6 +2,7 @@ Contributors since the last release: =20 Christopher Baines Greg Benison + Nathan Borghese Rob Browning Tristan Colgate-McFarlane Aleix Conchillo Flaqu=C3=A9 diff --git a/module/web/uri.scm b/module/web/uri.scm index 2280976b5..708205136 100644 --- a/module/web/uri.scm +++ b/module/web/uri.scm @@ -1,7 +1,7 @@ ;;;; (web uri) --- URI manipulation tools ;;;; ;;;; Copyright (C) 1997,2001,2002,2010,2011,2012,2013,2014,2019-2021 Free = Software Foundation, Inc. -;;;; Copyright (C) 2023 Vivien Kraus +;;;; Copyright (C) 2023 Nathan Borghese ;;;; ;;;; This library is free software; you can redistribute it and/or ;;;; modify it under the terms of the GNU Lesser General Public --=20 2.41.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Vivien Kraus writes: > Le lundi 27 novembre 2023 =C3=A0 18:10 +0100, Vivien Kraus a =C3=A9crit= =C2=A0: >> Dear Guile developers, >>=20 >> Some time ago, Nathan wrote this patch as a better version of mine, >> and >> I would really like to see it merged. >>=20 >> Does it need more improvement? I consider it pretty good. > > Maybe I spoke too soon: the AUTHORS file and the copyright file header > should not mention me for uri.scm, but Nathan, as this version did not > retain significant work by me. > > Vivien --=-=-=--