From: Eli Zaretskii <eliz@gnu.org>
To: ludo@gnu.org (Ludovic Courtès)
Cc: 10474@debbugs.gnu.org, commander.sirow@googlemail.com
Subject: bug#10474: Building guile 2.x under mingw + msys
Date: Thu, 26 Jan 2012 00:37:46 -0500 [thread overview]
Message-ID: <E1RqI1q-0006SD-FR@fencepost.gnu.org> (raw)
In-Reply-To: <87k44ffpwb.fsf@gnu.org> (ludo@gnu.org)
> From: ludo@gnu.org (Ludovic Courtès)
> Cc: 10474@debbugs.gnu.org, commander.sirow@googlemail.com
> Date: Wed, 25 Jan 2012 22:12:04 +0100
>
> Thanks for doing all the hard work!
Thanks for developing Guile.
> I’m willing to apply your changes, but could you send them in ‘git
> format-patch’ format, with a log in GNU ChangeLog style, to make it
> easier?
I can certainly add ChangeLog entries, but `git format-patch' would be
harder. I don't have git installed on my development machine (git is
a bit of PITA on Windows). What's wrong with "diff -u"? I can divide
the diffs into separate chunks of related changes, so it will be
easier for you to produce separate commits, if that's what you want
from `git format-patch'. If there's another reason for your request,
please tell what that is and I will try to make your job easier as
much as I can. But installing git and cloning the Guile repo just to
submit these changes is something I'd like to avoid if possible.
> In prevision of the of an increased contribution rate ;-), could you
> assign copyright to the FSF?
Will do.
> Strangely enough, the cross-build to MinGW32 at
> <http://hydra.nixos.org/jobset/gnu/guile-2-0/> is not showing any of
> these. Any idea why? That’s with MinGW 3.18.
I have exactly zero experience with the cross-build MinGW
environment. My MinGW installation is 3.14, FWIW.
> > is inappropriate when gnulib was used to wrap Windows socket
> > functions. When gnulib _is_ used, the missing macros are already
> > defined by lib/sys/socket.h. Therefore, I modified the condition to:
> >
> > #if HAVE_WINSOCK2_H && !GNULIB_TEST_SOCKET
> > #include <winsock2.h>
> > # if HAVE_WS2TCPIP_H
> > # include <ws2tcpip.h>
> > # endif
> > #else
> > #include <sys/socket.h>
> > #include <netdb.h>
> > #include <netinet/in.h>
> > #include <arpa/inet.h>
> > #endif
> >
> > using GNULIB_TEST_SOCKET as evidence that gnulib is being used. I'm
> > not sure GNULIB_TEST_SOCKET is TRT, but I saw no better candidate.
> > Maybe gnulib should provide us with a better macro.
>
> This seems to be the right thing, according to gnulib-common.m4:
OK.
next prev parent reply other threads:[~2012-01-26 5:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAL+StqnixLW+QwOP2BpZrjnz1wAQjnio9H6P=VM=9Cnn-B2-ng@mail.gmail.com>
2012-01-10 22:00 ` bug#10474: Building guile 2.x under mingw + msys Andy Wingo
[not found] ` <87pqerdxq4.fsf@pobox.com>
2012-01-17 8:09 ` Eli Zaretskii
2012-01-17 18:14 ` Eli Zaretskii
2012-01-18 23:55 ` Ludovic Courtès
2012-01-19 4:04 ` Eli Zaretskii
2012-02-02 0:59 ` Andy Wingo
2012-02-02 3:53 ` Eli Zaretskii
2012-02-02 16:39 ` Ludovic Courtès
2012-02-02 17:14 ` Eli Zaretskii
2012-02-02 17:34 ` Eli Zaretskii
2013-02-18 18:10 ` Andy Wingo
2013-02-18 19:56 ` Eli Zaretskii
2013-02-19 10:44 ` Andy Wingo
2013-02-19 12:55 ` Ludovic Courtès
2013-02-19 13:39 ` Andy Wingo
2013-02-19 17:53 ` Eli Zaretskii
2013-02-19 21:44 ` Andy Wingo
2013-02-20 19:16 ` Eli Zaretskii
2013-02-24 12:08 ` Andy Wingo
2013-02-19 15:47 ` Andy Wingo
2013-02-19 18:00 ` Eli Zaretskii
2013-02-24 13:25 ` Andy Wingo
2013-02-24 15:43 ` Eli Zaretskii
2013-05-07 17:18 ` bug#14361: Building guile 2.0.9 " Eli Zaretskii
2016-06-20 21:19 ` Andy Wingo
2016-06-21 12:46 ` Eli Zaretskii
2016-06-21 15:06 ` Andy Wingo
2016-06-21 15:42 ` Eli Zaretskii
2016-06-21 20:52 ` Andy Wingo
2016-06-24 9:51 ` Eli Zaretskii
2013-02-19 21:39 ` bug#10474: Building guile 2.x " Andy Wingo
2013-02-20 19:14 ` Eli Zaretskii
2013-02-20 21:57 ` Andy Wingo
2013-02-21 3:49 ` Eli Zaretskii
2013-02-21 8:18 ` Andy Wingo
2012-01-19 17:35 ` Eli Zaretskii
2012-01-21 11:09 ` Eli Zaretskii
2012-01-24 12:27 ` Eli Zaretskii
2012-01-25 21:12 ` Ludovic Courtès
2012-01-26 5:37 ` Eli Zaretskii [this message]
2012-01-29 18:30 ` Ludovic Courtès
2012-01-29 19:17 ` Eli Zaretskii
2012-01-29 22:56 ` Ludovic Courtès
2012-01-10 21:58 Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1RqI1q-0006SD-FR@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=10474@debbugs.gnu.org \
--cc=commander.sirow@googlemail.com \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).