From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.lisp.guile.bugs Subject: bug#10474: Building guile 2.x under mingw + msys Date: Thu, 26 Jan 2012 00:37:46 -0500 Message-ID: References: <87pqerdxq4.fsf@pobox.com> <83ehuy698u.fsf@gnu.org> <8362ga5h7h.fsf@gnu.org> <87r4ywpnv0.fsf@gnu.org> <83obtz4muv.fsf@gnu.org> <83r4yt2tyj.fsf@gnu.org> <87k44ffpwb.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1327556325 16116 80.91.229.12 (26 Jan 2012 05:38:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 26 Jan 2012 05:38:45 +0000 (UTC) Cc: 10474@debbugs.gnu.org, commander.sirow@googlemail.com To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Jan 26 06:38:39 2012 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RqI2g-00070V-U3 for guile-bugs@m.gmane.org; Thu, 26 Jan 2012 06:38:39 +0100 Original-Received: from localhost ([::1]:34318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqI2f-0002YE-VE for guile-bugs@m.gmane.org; Thu, 26 Jan 2012 00:38:37 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:33718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqI2c-0002Y8-7F for bug-guile@gnu.org; Thu, 26 Jan 2012 00:38:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqI2a-0007L6-Pt for bug-guile@gnu.org; Thu, 26 Jan 2012 00:38:33 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqI2a-0007L2-Lg for bug-guile@gnu.org; Thu, 26 Jan 2012 00:38:32 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RqI33-0005ar-RS for bug-guile@gnu.org; Thu, 26 Jan 2012 00:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 26 Jan 2012 05:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10474 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 10474-submit@debbugs.gnu.org id=B10474.132755630521455 (code B ref 10474); Thu, 26 Jan 2012 05:39:01 +0000 Original-Received: (at 10474) by debbugs.gnu.org; 26 Jan 2012 05:38:25 +0000 Original-Received: from localhost ([127.0.0.1]:44859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqI2P-0005Zu-Hz for submit@debbugs.gnu.org; Thu, 26 Jan 2012 00:38:22 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:60205 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqI2L-0005Zm-JV for 10474@debbugs.gnu.org; Thu, 26 Jan 2012 00:38:19 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RqI1q-0006SD-FR; Thu, 26 Jan 2012 00:37:46 -0500 In-reply-to: <87k44ffpwb.fsf@gnu.org> (ludo@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:6086 Archived-At: > From: ludo@gnu.org (Ludovic Courtès) > Cc: 10474@debbugs.gnu.org, commander.sirow@googlemail.com > Date: Wed, 25 Jan 2012 22:12:04 +0100 > > Thanks for doing all the hard work! Thanks for developing Guile. > I’m willing to apply your changes, but could you send them in ‘git > format-patch’ format, with a log in GNU ChangeLog style, to make it > easier? I can certainly add ChangeLog entries, but `git format-patch' would be harder. I don't have git installed on my development machine (git is a bit of PITA on Windows). What's wrong with "diff -u"? I can divide the diffs into separate chunks of related changes, so it will be easier for you to produce separate commits, if that's what you want from `git format-patch'. If there's another reason for your request, please tell what that is and I will try to make your job easier as much as I can. But installing git and cloning the Guile repo just to submit these changes is something I'd like to avoid if possible. > In prevision of the of an increased contribution rate ;-), could you > assign copyright to the FSF? Will do. > Strangely enough, the cross-build to MinGW32 at > is not showing any of > these. Any idea why? That’s with MinGW 3.18. I have exactly zero experience with the cross-build MinGW environment. My MinGW installation is 3.14, FWIW. > > is inappropriate when gnulib was used to wrap Windows socket > > functions. When gnulib _is_ used, the missing macros are already > > defined by lib/sys/socket.h. Therefore, I modified the condition to: > > > > #if HAVE_WINSOCK2_H && !GNULIB_TEST_SOCKET > > #include > > # if HAVE_WS2TCPIP_H > > # include > > # endif > > #else > > #include > > #include > > #include > > #include > > #endif > > > > using GNULIB_TEST_SOCKET as evidence that gnulib is being used. I'm > > not sure GNULIB_TEST_SOCKET is TRT, but I saw no better candidate. > > Maybe gnulib should provide us with a better macro. > > This seems to be the right thing, according to gnulib-common.m4: OK.