* bug#26123: guile-2.2.0: AI_ADDRCONFIG
@ 2017-03-16 9:29 Thomas Klausner
2017-03-17 13:11 ` dsmich
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Klausner @ 2017-03-16 9:29 UTC (permalink / raw)
To: 26123
Hi!
When compiling guile-2.2.0 on NetBSD_7.99.65/amd64, I see:
SNARF net_db.doc
net_db.c:468:***Missing or erroneous `#define FUNC_NAME s_AI_ADDRCONFIG);'
net_db.c:488:***Missing or erroneous #undef for AI_ADDRCONFIG);:
Compilation continues even though this looks like an error.
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#26123: guile-2.2.0: AI_ADDRCONFIG
2017-03-16 9:29 bug#26123: guile-2.2.0: AI_ADDRCONFIG Thomas Klausner
@ 2017-03-17 13:11 ` dsmich
2017-04-19 14:50 ` Andy Wingo
0 siblings, 1 reply; 3+ messages in thread
From: dsmich @ 2017-03-17 13:11 UTC (permalink / raw)
To: 26123
---- Thomas Klausner <tk@giga.or.at> wrote:
>
> SNARF net_db.doc
> net_db.c:468:***Missing or erroneous `#define FUNC_NAME s_AI_ADDRCONFIG);'
> net_db.c:488:***Missing or erroneous #undef for AI_ADDRCONFIG);:
>
> Compilation continues even though this looks like an error.
Yeah, while annoying, this is harmless.
The proper fix in my opinion is to limit the regular expression on line 28 in libguile/guile-func-name-check to only match function definition macros. Currently, it matches other macros that define things other than functions, and so erroneously looks for a function body.
For example, adding a space like /^SCM_DEFINE / would probably be appropriate. However, that would prevent it from matching any other function defining macros, if they exist.
-Dale
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#26123: guile-2.2.0: AI_ADDRCONFIG
2017-03-17 13:11 ` dsmich
@ 2017-04-19 14:50 ` Andy Wingo
0 siblings, 0 replies; 3+ messages in thread
From: Andy Wingo @ 2017-04-19 14:50 UTC (permalink / raw)
To: dsmich; +Cc: 26123-done
On Fri 17 Mar 2017 14:11, <dsmich@roadrunner.com> writes:
> ---- Thomas Klausner <tk@giga.or.at> wrote:
>>
>> SNARF net_db.doc
>> net_db.c:468:***Missing or erroneous `#define FUNC_NAME s_AI_ADDRCONFIG);'
>> net_db.c:488:***Missing or erroneous #undef for AI_ADDRCONFIG);:
>>
>> Compilation continues even though this looks like an error.
>
> Yeah, while annoying, this is harmless.
>
> The proper fix in my opinion is to limit the regular expression on line
> 28 in libguile/guile-func-name-check to only match function definition
> macros. Currently, it matches other macros that define things other
> than functions, and so erroneously looks for a function body.
>
> For example, adding a space like /^SCM_DEFINE / would probably be appropriate. However, that would prevent it from matching any other function defining macros, if they exist.
Good idea, done. Thanks :)
ANdy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-19 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-16 9:29 bug#26123: guile-2.2.0: AI_ADDRCONFIG Thomas Klausner
2017-03-17 13:11 ` dsmich
2017-04-19 14:50 ` Andy Wingo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).