unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: <dsmich@roadrunner.com>
To: 26123@debbugs.gnu.org
Subject: bug#26123: guile-2.2.0: AI_ADDRCONFIG
Date: Fri, 17 Mar 2017 9:11:45 -0400	[thread overview]
Message-ID: <20170317131145.HJ8BG.174715.root@cdptpa-web10> (raw)
In-Reply-To: <20170316092918.4eh35k32ky4edya7@danbala>


---- Thomas Klausner <tk@giga.or.at> wrote: 
> 
>   SNARF  net_db.doc
> net_db.c:468:***Missing or erroneous `#define FUNC_NAME s_AI_ADDRCONFIG);'
> net_db.c:488:***Missing or erroneous #undef for AI_ADDRCONFIG);:
> 
> Compilation continues even though this looks like an error.

Yeah,  while annoying, this is harmless.

The proper fix in my opinion is to limit the regular expression on line 28 in libguile/guile-func-name-check to only match function definition macros.  Currently, it matches other macros that define things other than functions, and so erroneously looks for a function body.

For example, adding a space like /^SCM_DEFINE / would probably be appropriate.  However, that would prevent it from matching any other function defining macros, if they exist.

-Dale
 






  reply	other threads:[~2017-03-17 13:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16  9:29 bug#26123: guile-2.2.0: AI_ADDRCONFIG Thomas Klausner
2017-03-17 13:11 ` dsmich [this message]
2017-04-19 14:50   ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170317131145.HJ8BG.174715.root@cdptpa-web10 \
    --to=dsmich@roadrunner.com \
    --cc=26123@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).