* bug#18495: [PATCH] Fix SCM_SMOB_OBJECT_LOC
@ 2014-09-18 7:32 David Kastrup
2014-09-18 7:39 ` bug#18495: Alternatives? David Kastrup
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: David Kastrup @ 2014-09-18 7:32 UTC (permalink / raw)
To: 18495; +Cc: David Kastrup
* libguile/smob.h (SCM_SMOB_OBJECT_LOC): This elementary API macro has
been broken by commit 56164dc47f6616b359f0ad23be208f01a77b55fa in 2009
Signed-off-by: David Kastrup <dak@gnu.org>
---
libguile/smob.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libguile/smob.h b/libguile/smob.h
index 60abe37..e787cb1 100644
--- a/libguile/smob.h
+++ b/libguile/smob.h
@@ -163,7 +163,7 @@ scm_new_double_smob (scm_t_bits tc, scm_t_bits data1,
#define SCM_SMOB_OBJECT(x) (SCM_SMOB_OBJECT_1 (x))
#define SCM_SET_SMOB_OBJECT(x,obj) (SCM_SET_SMOB_OBJECT_1 ((x), (obj)))
-#define SCM_SMOB_OBJECT_LOC(x) (SCM_SMOB_OBJECT_1_LOC (x)))
+#define SCM_SMOB_OBJECT_LOC(x) (SCM_SMOB_OBJECT_1_LOC (x))
#define SCM_SMOB_APPLY_0(x) (scm_call_0 (x))
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#18495: Alternatives?
2014-09-18 7:32 bug#18495: [PATCH] Fix SCM_SMOB_OBJECT_LOC David Kastrup
@ 2014-09-18 7:39 ` David Kastrup
2014-09-18 8:40 ` bug#18495: [PATCH] Fix SCM_SMOB_OBJECT{_,_0_,_1_,_2_,_3_}LOC David Kastrup
2014-09-18 8:50 ` bug#18495: Alternatives!?! David Kastrup
2 siblings, 0 replies; 5+ messages in thread
From: David Kastrup @ 2014-09-18 7:39 UTC (permalink / raw)
To: 18495
Any suggestions what non-deprecated alternative should be used instead
of SCM_SMOB_OBJECT_LOC in the year that it will take until this fix is
generally available?
--
David Kastrup
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18495: [PATCH] Fix SCM_SMOB_OBJECT{_,_0_,_1_,_2_,_3_}LOC
2014-09-18 7:32 bug#18495: [PATCH] Fix SCM_SMOB_OBJECT_LOC David Kastrup
2014-09-18 7:39 ` bug#18495: Alternatives? David Kastrup
@ 2014-09-18 8:40 ` David Kastrup
2014-09-18 8:50 ` bug#18495: Alternatives!?! David Kastrup
2 siblings, 0 replies; 5+ messages in thread
From: David Kastrup @ 2014-09-18 8:40 UTC (permalink / raw)
To: 18495; +Cc: David Kastrup
* libguile/smob.h (SCM_SMOB_OBJECT_LOC, SCM_SMOB_OBJECT_0_LOC)
(SCM_SMOB_OBJECT_1_LOC, SCM_SMOB_OBJECT_2_LOC)
(SCM_SMOB_OBJECT_3_LOC): These elementary API macros have been broken
by commit 56164dc47f6616b359f0ad23be208f01a77b55fa in 2009
Signed-off-by: David Kastrup <dak@gnu.org>
---
libguile/smob.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libguile/smob.h b/libguile/smob.h
index 60abe37..f910a24 100644
--- a/libguile/smob.h
+++ b/libguile/smob.h
@@ -156,14 +156,14 @@ scm_new_double_smob (scm_t_bits tc, scm_t_bits data1,
#define SCM_SET_SMOB_OBJECT_1(x,obj) (SCM_SET_SMOB_OBJECT_N ((x), 1, (obj)))
#define SCM_SET_SMOB_OBJECT_2(x,obj) (SCM_SET_SMOB_OBJECT_N ((x), 2, (obj)))
#define SCM_SET_SMOB_OBJECT_3(x,obj) (SCM_SET_SMOB_OBJECT_N ((x), 3, (obj)))
-#define SCM_SMOB_OBJECT_0_LOC(x) (SCM_SMOB_OBJECT_N_LOC ((x), 0)))
-#define SCM_SMOB_OBJECT_1_LOC(x) (SCM_SMOB_OBJECT_N_LOC ((x), 1)))
-#define SCM_SMOB_OBJECT_2_LOC(x) (SCM_SMOB_OBJECT_N_LOC ((x), 2)))
-#define SCM_SMOB_OBJECT_3_LOC(x) (SCM_SMOB_OBJECT_N_LOC ((x), 3)))
+#define SCM_SMOB_OBJECT_0_LOC(x) (SCM_SMOB_OBJECT_N_LOC ((x), 0))
+#define SCM_SMOB_OBJECT_1_LOC(x) (SCM_SMOB_OBJECT_N_LOC ((x), 1))
+#define SCM_SMOB_OBJECT_2_LOC(x) (SCM_SMOB_OBJECT_N_LOC ((x), 2))
+#define SCM_SMOB_OBJECT_3_LOC(x) (SCM_SMOB_OBJECT_N_LOC ((x), 3))
#define SCM_SMOB_OBJECT(x) (SCM_SMOB_OBJECT_1 (x))
#define SCM_SET_SMOB_OBJECT(x,obj) (SCM_SET_SMOB_OBJECT_1 ((x), (obj)))
-#define SCM_SMOB_OBJECT_LOC(x) (SCM_SMOB_OBJECT_1_LOC (x)))
+#define SCM_SMOB_OBJECT_LOC(x) (SCM_SMOB_OBJECT_1_LOC (x))
#define SCM_SMOB_APPLY_0(x) (scm_call_0 (x))
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#18495: Alternatives!?!
2014-09-18 7:32 bug#18495: [PATCH] Fix SCM_SMOB_OBJECT_LOC David Kastrup
2014-09-18 7:39 ` bug#18495: Alternatives? David Kastrup
2014-09-18 8:40 ` bug#18495: [PATCH] Fix SCM_SMOB_OBJECT{_,_0_,_1_,_2_,_3_}LOC David Kastrup
@ 2014-09-18 8:50 ` David Kastrup
2014-09-20 12:42 ` Mark H Weaver
2 siblings, 1 reply; 5+ messages in thread
From: David Kastrup @ 2014-09-18 8:50 UTC (permalink / raw)
To: 18495
Well, since the obvious fallback of using SCM_SMOB_OBJECT_1_LOC is
barred since _all_ of SCM_SMOB_OBJECT_LOC, SCM_SMOB_OBJECT_0_LOC,
SCM_SMOB_OBJECT_1_LOC, SCM_SMOB_OBJECT_2_LOC, SCM_SMOB_OBJECT_3_LOC are
broken, will there be something like an official guarantee that using
the undocumented SCM_SMOB_OBJECT_N_LOC will be supported for several
years? Or is one supposed to use the undocumented SCM_CELL_OBJECT_LOC
instead?
I don't see any _documented_ accessor to SMOB cell locations that would
not be broken in the current source.
This is sort of important.
--
David Kastrup
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18495: Alternatives!?!
2014-09-18 8:50 ` bug#18495: Alternatives!?! David Kastrup
@ 2014-09-20 12:42 ` Mark H Weaver
0 siblings, 0 replies; 5+ messages in thread
From: Mark H Weaver @ 2014-09-20 12:42 UTC (permalink / raw)
To: David Kastrup; +Cc: 18495-done
David Kastrup <dak@gnu.org> writes:
> * libguile/smob.h (SCM_SMOB_OBJECT_LOC, SCM_SMOB_OBJECT_0_LOC)
> (SCM_SMOB_OBJECT_1_LOC, SCM_SMOB_OBJECT_2_LOC)
> (SCM_SMOB_OBJECT_3_LOC): These elementary API macros have been broken
> by commit 56164dc47f6616b359f0ad23be208f01a77b55fa in 2009
Ouch. I've pushed this to stable-2.0, commit
8442211ef0029581b35f784489afcf210491fc41. I'm closing this bug.
> will there be something like an official guarantee that using
> the undocumented SCM_SMOB_OBJECT_N_LOC will be supported for several
> years?
I think that's the best option. Just use SCM_SMOB_OBJECT_N_LOC.
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-20 12:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-18 7:32 bug#18495: [PATCH] Fix SCM_SMOB_OBJECT_LOC David Kastrup
2014-09-18 7:39 ` bug#18495: Alternatives? David Kastrup
2014-09-18 8:40 ` bug#18495: [PATCH] Fix SCM_SMOB_OBJECT{_,_0_,_1_,_2_,_3_}LOC David Kastrup
2014-09-18 8:50 ` bug#18495: Alternatives!?! David Kastrup
2014-09-20 12:42 ` Mark H Weaver
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).