unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#26583: 2.2.1 syntax objects are not comparable
@ 2017-04-20 20:52 Ludovic Courtès
  2017-04-21  7:38 ` Andy Wingo
  0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2017-04-20 20:52 UTC (permalink / raw)
  To: 26583, wingo

Hello,

The “new” syntax objects in 2.2.1 cannot be compared with ‘equal?’,
unlike the “old” ones, which were just vectors.

It’s easy to fix in libguile, but was it intended?  If not, I’ll happily
send a patch.

Of course syntax objects were never officially comparable, but it turns
out that the ‘gexp’ macro in (guix gexp) relies on that when it rewrites
the syntax tree.

I tried to see if we could implement this macro differently, without
doing an explicit tree traversal, possibly using syntax parameters for
‘ungexp’ & co.  However, the difficulty is that the job of this macro
cannot be done in a single pass AFAICS.

Thoughts?

Ludo’.





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#26583: 2.2.1 syntax objects are not comparable
  2017-04-20 20:52 bug#26583: 2.2.1 syntax objects are not comparable Ludovic Courtès
@ 2017-04-21  7:38 ` Andy Wingo
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Wingo @ 2017-04-21  7:38 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 26583

On Thu 20 Apr 2017 22:52, ludo@gnu.org (Ludovic Courtès) writes:

> The “new” syntax objects in 2.2.1 cannot be compared with ‘equal?’,
> unlike the “old” ones, which were just vectors.

I think this is a bug.  We can roll another release today.

Andy





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-21  7:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 20:52 bug#26583: 2.2.1 syntax objects are not comparable Ludovic Courtès
2017-04-21  7:38 ` Andy Wingo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).