unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: 26583@debbugs.gnu.org, wingo@igalia.com
Subject: bug#26583: 2.2.1 syntax objects are not comparable
Date: Thu, 20 Apr 2017 22:52:59 +0200	[thread overview]
Message-ID: <87pog6ls2c.fsf@gnu.org> (raw)

Hello,

The “new” syntax objects in 2.2.1 cannot be compared with ‘equal?’,
unlike the “old” ones, which were just vectors.

It’s easy to fix in libguile, but was it intended?  If not, I’ll happily
send a patch.

Of course syntax objects were never officially comparable, but it turns
out that the ‘gexp’ macro in (guix gexp) relies on that when it rewrites
the syntax tree.

I tried to see if we could implement this macro differently, without
doing an explicit tree traversal, possibly using syntax parameters for
‘ungexp’ & co.  However, the difficulty is that the job of this macro
cannot be done in a single pass AFAICS.

Thoughts?

Ludo’.





             reply	other threads:[~2017-04-20 20:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20 20:52 Ludovic Courtès [this message]
2017-04-21  7:38 ` bug#26583: 2.2.1 syntax objects are not comparable Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pog6ls2c.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26583@debbugs.gnu.org \
    --cc=wingo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).