Re: Finalizing 'inhibit-automatic-native-compilation'

[Andrea Corallo <akrl@sdf.org>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: emacs-devel@gnu.org,  Lars Ingebrigtsen <larsi@gnus.org>,  Stefan
>>  Monnier <monnier@iro.umontreal.ca>,  Rob Browning <rlb@defaultvalue.org>
>> Date: Mon, 13 Feb 2023 12:05:09 +0000
>> 
>> Hello all,
>> 
>> at feature/inhibit-native-comp-cleanup I've pushed the branch I'm
>> testing that:
>> 
>>   . removes the EMACS_INHIBIT_AUTOMATIC_NATIVE_COMPILATION environment
>>     variable
>>   . removes `inhibit-automatic-native-compilation' variable and uses
>>     `native-comp-deferred-compilation', with or without
>>     `comp-enable-subr-trampolines' (as needed), instead
>>   . adds a third possible value to `comp-enable-subr-trampolines', a
>>     string that specifies a directory in which to deposit the JIT
>>     compiled trampolines
>>   . updates the doc string of `native-comp-never-optimize-functions' to
>>     mention its effect on trampolines
>>   . updates some do doc here and there accordingly 
>
> Thanks, I will take a look shortly.

Thanks, feel free to suggest improvements or implement them directly if
you feel.

>> - I think renaming `native-comp-deferred-compilation' to
>>   `native-comp-jit-compilation' might be more descriptive to the user
>>   but I guess we are late now? :/
>> 
>> - If `comp-enable-subr-trampolines' is meant to be used by the user we
>>   should probably rename it into `native-comp-enable-subr-trampolines'?
>>   I guess we are late as well?
>
> We can add new names, and make the old ones obsolete aliases.  Then we
> could remove the obsolete aliases in some future release.

Cool, can we obsolete the old names already in emacs 29 or shall we do
it in 30?

Andrea