From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Finalizing 'inhibit-automatic-native-compilation' Date: Mon, 13 Feb 2023 15:21:12 +0000 Message-ID: References: <837cx8cey0.fsf@gnu.org> <83fsb9g0ts.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15754"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca, rlb@defaultvalue.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 13 16:21:53 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRaeP-0003pq-JQ for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Feb 2023 16:21:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRadr-00052W-GA; Mon, 13 Feb 2023 10:21:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRadq-00052G-CK for emacs-devel@gnu.org; Mon, 13 Feb 2023 10:21:18 -0500 Original-Received: from mab.sdf.org ([205.166.94.33] helo=ma.sdf.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRado-0004Pm-AW; Mon, 13 Feb 2023 10:21:17 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1pRadk-0006Vr-Di; Mon, 13 Feb 2023 15:21:12 +0000 In-Reply-To: <83fsb9g0ts.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 13 Feb 2023 15:19:11 +0200") Received-SPF: pass client-ip=205.166.94.33; envelope-from=akrl@sdf.org; helo=ma.sdf.org X-Spam_score_int: 31 X-Spam_score: 3.1 X-Spam_bar: +++ X-Spam_report: (3.1 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL=1.31, RCVD_IN_XBL=0.375, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303219 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: emacs-devel@gnu.org, Lars Ingebrigtsen , Stefan >> Monnier , Rob Browning >> Date: Mon, 13 Feb 2023 12:05:09 +0000 >> >> Hello all, >> >> at feature/inhibit-native-comp-cleanup I've pushed the branch I'm >> testing that: >> >> . removes the EMACS_INHIBIT_AUTOMATIC_NATIVE_COMPILATION environment >> variable >> . removes `inhibit-automatic-native-compilation' variable and uses >> `native-comp-deferred-compilation', with or without >> `comp-enable-subr-trampolines' (as needed), instead >> . adds a third possible value to `comp-enable-subr-trampolines', a >> string that specifies a directory in which to deposit the JIT >> compiled trampolines >> . updates the doc string of `native-comp-never-optimize-functions' to >> mention its effect on trampolines >> . updates some do doc here and there accordingly > > Thanks, I will take a look shortly. Thanks, feel free to suggest improvements or implement them directly if you feel. >> - I think renaming `native-comp-deferred-compilation' to >> `native-comp-jit-compilation' might be more descriptive to the user >> but I guess we are late now? :/ >> >> - If `comp-enable-subr-trampolines' is meant to be used by the user we >> should probably rename it into `native-comp-enable-subr-trampolines'? >> I guess we are late as well? > > We can add new names, and make the old ones obsolete aliases. Then we > could remove the obsolete aliases in some future release. Cool, can we obsolete the old names already in emacs 29 or shall we do it in 30? Andrea