From: lux <lx@shellcodes.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: Ruijie Yu <ruijie@netyu.xyz>, 60562@debbugs.gnu.org, eliz@gnu.org
Subject: bug#60562: [PATCH] Fix split-string error if there is a space in the filename.
Date: Mon, 09 Jan 2023 22:55:58 +0800 [thread overview]
Message-ID: <tencent_601DBB3C49F840B00927C04C4A4D530DD006@qq.com> (raw)
In-Reply-To: <87eds3hje9.fsf@gmail.com> (Robert Pluim's message of "Mon, 09 Jan 2023 15:28:30 +0100")
Robert Pluim <rpluim@gmail.com> writes:
> >>
> >> Also, in this change, we are dropping the requirement that the found
> >> file are actually files, whereas we used to say "-type f". Is this
> >> change fine?
> >>
>
> `directory-files-recursively' by default only returns files (and the
> latest patch explicitly passes `nil' for INCLUDE-DIRECTORIES anyway)
>
"-type f" will return all regular files, `directory-files-recursively'
contains all types of files (socket, block, etc..), so I latest patch
added `file-regular-p' to check the file type.
next prev parent reply other threads:[~2023-01-09 14:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 22:56 bug#60562: [PATCH] Fix split-string error if there is a space in the filename lux
2023-01-06 9:48 ` Robert Pluim
2023-01-07 9:29 ` Eli Zaretskii
2023-01-07 11:16 ` Robert Pluim
2023-01-07 11:37 ` Eli Zaretskii
2023-01-07 13:56 ` Eli Zaretskii
2023-01-07 14:52 ` lux
2023-01-07 23:00 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-08 7:23 ` lux
2023-01-09 14:28 ` Robert Pluim
2023-01-09 14:55 ` lux [this message]
2023-01-14 9:12 ` Eli Zaretskii
2023-01-07 9:42 ` lux
2023-01-07 10:48 ` Eli Zaretskii
2023-01-15 12:33 ` Andy Moreton
2023-01-15 14:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_601DBB3C49F840B00927C04C4A4D530DD006@qq.com \
--to=lx@shellcodes.org \
--cc=60562@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rpluim@gmail.com \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.