all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 60562@debbugs.gnu.org, lx@shellcodes.org
Subject: bug#60562: [PATCH] Fix split-string error if there is a space in the filename.
Date: Sat, 07 Jan 2023 11:29:58 +0200	[thread overview]
Message-ID: <834jt2u1yh.fsf@gnu.org> (raw)
In-Reply-To: <87zgawgfic.fsf@gmail.com> (message from Robert Pluim on Fri, 06 Jan 2023 10:48:43 +0100)

> Cc: 60562@debbugs.gnu.org
> From: Robert Pluim <rpluim@gmail.com>
> Date: Fri, 06 Jan 2023 10:48:43 +0100
> 
> >>>>> On Thu, 5 Jan 2023 06:56:05 +0800, lux <lx@shellcodes.org> said:
> 
>     lux> * lisp/htmlfontify.el (hfy-list-files): Specify separator (\n\r).
>     lux> ---
>     lux>  lisp/htmlfontify.el | 5 +++--
>     lux>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
>     lux> diff --git a/lisp/htmlfontify.el b/lisp/htmlfontify.el
>     lux> index c989a12d205..be020b6b1c5 100644
>     lux> --- a/lisp/htmlfontify.el
>     lux> +++ b/lisp/htmlfontify.el
>     lux> @@ -1826,8 +1826,9 @@ hfy-list-files
>     lux>    ;;(message "hfy-list-files");;DBUG
>     lux>    ;; FIXME: this changes the dir of the current buffer.  Is that right??
>     lux>    (cd directory)
>     lux> -  (mapcar (lambda (F) (if (string-match "^./\\(.*\\)" F) (match-string 1 F) F))
>     lux> -          (split-string (shell-command-to-string hfy-find-cmd))) )
>     lux> +  (remove-if #'string-empty-p
>     lux> +             (mapcar (lambda (F) (if (string-match "^./\\(.*\\)" F) (match-string 1 F) F))
>     lux> +                     (split-string (shell-command-to-string hfy-find-cmd) "[\n\r]+")) ))
> 
> You can avoid the issue (and improve portability) by using
> `directory-files-recursively' instead of `find'

Right.  Would you like to rewrite the patch using
directory-files-recursively?

> (which is annoyingly
> hard to remember, since the obvious search leads to
> `list-directory'. Perhaps we should add `list-directory-recursively'
> as an alias?)

How did you search for it?





  reply	other threads:[~2023-01-07  9:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 22:56 bug#60562: [PATCH] Fix split-string error if there is a space in the filename lux
2023-01-06  9:48 ` Robert Pluim
2023-01-07  9:29   ` Eli Zaretskii [this message]
2023-01-07 11:16     ` Robert Pluim
2023-01-07 11:37       ` Eli Zaretskii
2023-01-07 13:56         ` Eli Zaretskii
2023-01-07 14:52     ` lux
2023-01-07 23:00       ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-08  7:23         ` lux
2023-01-09 14:28           ` Robert Pluim
2023-01-09 14:55             ` lux
2023-01-14  9:12           ` Eli Zaretskii
2023-01-07  9:42   ` lux
2023-01-07 10:48     ` Eli Zaretskii
2023-01-15 12:33       ` Andy Moreton
2023-01-15 14:07         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834jt2u1yh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60562@debbugs.gnu.org \
    --cc=lx@shellcodes.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.