From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: lux Newsgroups: gmane.emacs.bugs Subject: bug#60562: [PATCH] Fix split-string error if there is a space in the filename. Date: Mon, 09 Jan 2023 22:55:58 +0800 Message-ID: References: <87zgawgfic.fsf@gmail.com> <834jt2u1yh.fsf@gnu.org> <87eds3hje9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9356"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Ruijie Yu , 60562@debbugs.gnu.org, eliz@gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 09 15:57:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEtaH-0002BV-Hm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Jan 2023 15:57:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEtaC-0001Th-5Y; Mon, 09 Jan 2023 09:57:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEtaA-0001SD-RC for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 09:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEtaA-0006ox-I5 for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 09:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEtaA-0000Fw-9O for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 09:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: lux Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Jan 2023 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60562-submit@debbugs.gnu.org id=B60562.1673276174941 (code B ref 60562); Mon, 09 Jan 2023 14:57:02 +0000 Original-Received: (at 60562) by debbugs.gnu.org; 9 Jan 2023 14:56:14 +0000 Original-Received: from localhost ([127.0.0.1]:37952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEtZO-0000F5-9U for submit@debbugs.gnu.org; Mon, 09 Jan 2023 09:56:14 -0500 Original-Received: from out203-205-251-60.mail.qq.com ([203.205.251.60]:35336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEtZJ-0000EC-Nt for 60562@debbugs.gnu.org; Mon, 09 Jan 2023 09:56:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1673276160; bh=p/yy70uWulV/mdL57buh0BrHbNCe8/bMJHcYN/yzcHg=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ESMccpAQnJFjqBmcdAVeMu3MMYhq1iJmbOF/yIjQomx2xPC3oTmu4Yiul3nba/lza U99btXAFB0kdkf6lNp9wL+deKgZSm9dZgb7PnnHXznLTuKSzKpNhHcXunv3CTd+yCQ 26a3RSDSRuU54+3Dx6lXC6+BollKIypt8Ve26tvw= Original-Received: from lx-pc ([240e:399:e6f:ee32:f815:4044:ba50:97f9]) by newxmesmtplogicsvrsza10-0.qq.com (NewEsmtp) with SMTP id DFA2620F; Mon, 09 Jan 2023 22:55:58 +0800 X-QQ-mid: xmsmtpt1673276158tuclna190 X-QQ-XMAILINFO: Mrv6PNPZjcp6JuLLgREsn5NsjbIVvrJ6vskLDkEkvM9dQkaUQUtLWfCWUO+aaU LOIOYN7G1C05VsfczDYk8zWmn29iKThRRYy/SxjhubZozwWdWOIIUc57nHaReEmIspesDt+nVVaN R84J/SjR/tk9mJU2OaKAWZ/K5aq4kfV4EPLfrF6zPIVkGKAtQ81w1fNDHKCRYvGxEJH2BFk6p0eG D+RU0YpAZqGDplNfHjnlcoT43po1wT0a5C8/rbpr23dQKT7TWo3b93K48/ZexCgev/VEIZLrSZ7h 8rCev/6KjpAYkKdtunLn5hGN1X8nbjwS2YroAGD7pl0s2msAnQF0+ZE81mCzdU4bDIGzO6JVf8DH 2DClIV+a71Mnmb4h5FGGNR2UJXmklYnMsAPrig269FIXtuXSsHrF7pRgFwuxQXeEq6/xWSdH0jR+ pYD08mHPDoQOl6m4kK9GsblK5cs1xK6VVbHzaqvxaqM7TegOBSCJ/R0WmJOWQptKEFTolsTXDNTj Jy4hH6PLtBXsZ5cpHWuJBHIN4qurDijDw/yDb4va1AwZo5CrVJSCHBCGDlVcaUT14mqgUHV/7fOr GQhiy8hI0sfnO9XXzSt3l5aoQdkNYPHc1CJBEdMxHK9uQ4eSyYF+D9luNDRp1qPoynlkvWQ+GKvg NJ8w4N9m/wo/ehUdXyzyc/JYnt9tONNARmG+/hX5EPRA7eItsduHhHpnddbRDJQut6pZZC0e92IB 6lkecuuj09HivBIaiTAB1khtSbljFuW0LZs6BIhu5+CJ7fbmpx2OHqqm7zy8vwYmrj2+NePmzGC/ 3ABWdaiWtJ2uk6xLyks+G7Y7M0LQsAaYWiIikwKV In-Reply-To: <87eds3hje9.fsf@gmail.com> (Robert Pluim's message of "Mon, 09 Jan 2023 15:28:30 +0100") Original-Message-ID: <87pmbnu58h.fsf@shellcodes.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253025 Robert Pluim writes: > >> > >> Also, in this change, we are dropping the requirement that the found > >> file are actually files, whereas we used to say "-type f". Is this > >> change fine? > >> > > `directory-files-recursively' by default only returns files (and the > latest patch explicitly passes `nil' for INCLUDE-DIRECTORIES anyway) > "-type f" will return all regular files, `directory-files-recursively' contains all types of files (socket, block, etc..), so I latest patch added `file-regular-p' to check the file type.