Re: master f1a7cd71a04: Fix Dired when QUITING_STYLE is set in the environment

Re: master f1a7cd71a04: Fix Dired when QUITING_STYLE is set in the environment

[Ruijie Yu via Emacs development discussions.]

I noticed that there are two typos to "QUOTING_STYLE" -- not sure if it
warrants another commit fixing the code typo.


Eli Zaretskii <eliz@gnu.org> writes:

> branch: master
> commit f1a7cd71a04270e44845427daa896afe80b0acb0
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>     Fix Dired when QUITING_STYLE is set in the environment

Typo here.

>     * lisp/dired.el (dired-insert-directory): Ensure non-default
>     quoting style of file names is not used by 'ls' when we invoke it
>     with the --dired switch.  (Bug#63142)
> ---
>  lisp/dired.el | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index d1471e993a1..e3a9d7bc428 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -1653,7 +1653,10 @@ If HDR is non-nil, insert a header line with the directory name."
>  see `dired-use-ls-dired' for more details.")
>  		       nil))
>  	       dired-use-ls-dired)))
> -	(setq switches (concat "--dired " switches)))
> +        ;; Use -N with --dired, to countermand possible non-default
> +        ;; quoting style, in particular via the environment variable
> +        ;; QUOTINTG_STYLE.

Here as well.

> +	(setq switches (concat "--dired -N " switches)))
>      ;; Expand directory wildcards and fill file-list.
>      (let ((dir-wildcard (insert-directory-wildcard-in-dir-p dir)))
>        (cond (dir-wildcard


-- 
Best,


RY

[Please note that this mail might go to spam due to some
misconfiguration in my mail server -- still investigating.]

Re: master f1a7cd71a04: Fix Dired when QUITING_STYLE is set in the environment

[Eli Zaretskii]

> From: Ruijie Yu <ruijie@netyu.xyz>
> Cc: Emacs developers <emacs-devel@gnu.org>
> Date: Wed, 03 May 2023 08:46:13 +0800
> 
> I noticed that there are two typos to "QUOTING_STYLE" -- not sure if it
> warrants another commit fixing the code typo.

Thanks, I fixed the part I could.