all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ruijie Yu via "Emacs development discussions." <emacs-devel@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master f1a7cd71a04: Fix Dired when QUITING_STYLE is set in the environment
Date: Wed, 03 May 2023 08:46:13 +0800	[thread overview]
Message-ID: <sdvsfcei6id.fsf@netyu.xyz> (raw)
In-Reply-To: <20230502174613.DB0F2C0004A@vcs2.savannah.gnu.org>


I noticed that there are two typos to "QUOTING_STYLE" -- not sure if it
warrants another commit fixing the code typo.


Eli Zaretskii <eliz@gnu.org> writes:

> branch: master
> commit f1a7cd71a04270e44845427daa896afe80b0acb0
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>     Fix Dired when QUITING_STYLE is set in the environment

Typo here.

>     * lisp/dired.el (dired-insert-directory): Ensure non-default
>     quoting style of file names is not used by 'ls' when we invoke it
>     with the --dired switch.  (Bug#63142)
> ---
>  lisp/dired.el | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index d1471e993a1..e3a9d7bc428 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -1653,7 +1653,10 @@ If HDR is non-nil, insert a header line with the directory name."
>  see `dired-use-ls-dired' for more details.")
>  		       nil))
>  	       dired-use-ls-dired)))
> -	(setq switches (concat "--dired " switches)))
> +        ;; Use -N with --dired, to countermand possible non-default
> +        ;; quoting style, in particular via the environment variable
> +        ;; QUOTINTG_STYLE.

Here as well.

> +	(setq switches (concat "--dired -N " switches)))
>      ;; Expand directory wildcards and fill file-list.
>      (let ((dir-wildcard (insert-directory-wildcard-in-dir-p dir)))
>        (cond (dir-wildcard


-- 
Best,


RY

[Please note that this mail might go to spam due to some
misconfiguration in my mail server -- still investigating.]



       reply	other threads:[~2023-05-03  0:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <168304957357.27283.16285630990353658152@vcs2.savannah.gnu.org>
     [not found] ` <20230502174613.DB0F2C0004A@vcs2.savannah.gnu.org>
2023-05-03  0:46   ` Ruijie Yu via Emacs development discussions. [this message]
2023-05-03 11:16     ` master f1a7cd71a04: Fix Dired when QUITING_STYLE is set in the environment Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sdvsfcei6id.fsf@netyu.xyz \
    --to=emacs-devel@gnu.org \
    --cc=eliz@gnu.org \
    --cc=ruijie@netyu.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.