From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: John Wiegley <johnw@gnu.org>
Cc: Christophe <ch.bollard@laposte.net>,
50470@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#50470: 27.1; 'company-mode' 'eshell'
Date: Tue, 25 Jan 2022 18:05:59 -0500 [thread overview]
Message-ID: <jwvfspbzarv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> (Dmitry Gutov's message of "Mon, 24 Jan 2022 03:50:59 +0200")
Hi John,
Could you explain to me some of the code of `pcomplete-parse-arguments`?
I know that was many years ago but hopefully there's still some fond
memories of how you designed it.
To be honest, the only part I sort-of understand are the first
5-6 lines. Then comes the `(let ((begin (pcomplete-begin 'last)))` and
after that I'm lost: it doesn't look like we're parsing arguments
any more.
E.g. Why/when would pcomplete-stub contain a list rather than a string?
Stefan
Dmitry Gutov [2022-01-24 03:50:59] wrote:
> Hi Stefan,
>
> On 23.01.2022 05:23, Stefan Monnier wrote:
>> And the 100% untested patch below is a suggestion for how to try and fix
>> those kinds of bugs.
>> Can someone try and maybe make it work?
>
> I've tried the patch, and it seems to work already, as well as fix this
> particular scenario. (Thanks!)
>
> Might as well install it, I think.
>
> There is a scenario that is more noticeably broken (yet actually better with
> this patch): a modification of bug#18951. Instead of
>
> ls *
>
> try
>
> ls ~/Docu*
>
> ...and [on master] the result is that the asterisk is replaced with the
> "common part" of the possible completions automatically. If there is
> nothing to expand with, the asterisk is similarly deleted.
>
> With your patch, we get the "Buffer is read-only" error in *Messages*
> instead, which is probably an improvement. Because it doesn't modify the
> input, nor break Company completions long-term (after the asterisk is
> removed).
>
> The offending functions is pcomplete-parse-arguments. There is some complex
> global state going on there, but the following addition seems to fix the
> problem:
>
> @@ -790,6 +804,9 @@ pcomplete-parse-arguments
> (common-stub (car completions))
> (c completions)
> (len (length common-stub)))
> + (unless pcomplete-allow-modifications
> + (setq pcomplete-stub (buffer-substring begin (point)))
> + (throw 'pcomplete-completions completions))
> (while (and c (> len 0))
> (while (and (> len 0)
> (not (string=
>
>
> Not sure if this new value of pcomplete-stub is always TRT, but it has
> passed a bunch of my experiments successfully.
next prev parent reply other threads:[~2022-01-25 23:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 6:23 bug#50470: 27.1; 'company-mode' 'eshell' Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-08 16:00 ` bug#50470: eshell Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-08 16:07 ` Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-09 1:57 ` bug#50470: 27.1; 'company-mode' 'eshell' Dmitry Gutov
2021-09-09 5:48 ` Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-09 12:06 ` Dmitry Gutov
2021-09-09 13:09 ` Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-09 23:30 ` Dmitry Gutov
2021-09-10 5:11 ` Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-05 22:06 ` Dmitry Gutov
2021-12-10 10:50 ` jakanakaevangeli
2021-12-10 13:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-13 2:45 ` Dmitry Gutov
2021-12-13 3:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-23 3:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-24 1:50 ` Dmitry Gutov
2022-01-25 23:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-06-04 22:29 ` Dmitry Gutov
2022-06-05 0:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-05 0:36 ` Dmitry Gutov
2022-06-05 0:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-05 23:45 ` Dmitry Gutov
2022-06-06 1:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-06 9:07 ` Dmitry Gutov
2022-06-07 15:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-07 22:39 ` Dmitry Gutov
2023-03-17 6:26 ` Jim Porter
2023-03-18 1:01 ` Dmitry Gutov
2023-03-18 6:36 ` Jim Porter
2023-03-19 18:39 ` Jim Porter
2023-03-20 0:30 ` Jim Porter
2023-03-20 1:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-21 2:30 ` Jim Porter
2023-03-28 0:41 ` Dmitry Gutov
2023-03-28 4:06 ` Jim Porter
2023-03-28 6:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-28 17:43 ` Drew Adams
2023-03-28 19:35 ` Jim Porter
2023-03-28 21:21 ` Dmitry Gutov
2022-06-05 23:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-07 22:10 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfspbzarv.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=50470@debbugs.gnu.org \
--cc=ch.bollard@laposte.net \
--cc=dgutov@yandex.ru \
--cc=johnw@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.