From: Dmitry Gutov <dgutov@yandex.ru>
To: Jim Porter <jporterbugs@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Christophe <ch.bollard@laposte.net>,
50470@debbugs.gnu.org, John Wiegley <johnw@gnu.org>
Subject: bug#50470: 27.1; 'company-mode' 'eshell'
Date: Sat, 18 Mar 2023 03:01:11 +0200 [thread overview]
Message-ID: <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> (raw)
In-Reply-To: <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com>
On 17/03/2023 08:26, Jim Porter wrote:
> I've recently been digging through how Eshell and Pcomplete interact, so
> I think I understand what's happening here.
Thanks!
> On 6/7/2022 3:39 PM, Dmitry Gutov wrote:
>> pcomplete-completions-at-point somehow has pcomplete-stub pointing to
>> the necessary value (e.g. "/home/dgutov/Do") in the asterisk-less
>> cases (due to some other code path being taken), but not in this
>> specific one.
>
> I believe the problem is that when Eshell parses the command line to
> figure out what to give Pcomplete, it expands the globs itself, so
> things get messed up. So we want to prevent glob-expansion before
> passing to Pcomplete.
>
> The below patch does this, but it's probably not the right way to do it.
> However, it's a simple change, and before I go through the larger
> effort of a proper patch, I want to be sure I'm actually solving the
> right thing.
I can't comment on the exact right way to implement this, but the patch
does seem to solve the remaining problem here. Which is completion for
inputs containing *. The result looks rather nice.
next prev parent reply other threads:[~2023-03-18 1:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 6:23 bug#50470: 27.1; 'company-mode' 'eshell' Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-08 16:00 ` bug#50470: eshell Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-08 16:07 ` Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-09 1:57 ` bug#50470: 27.1; 'company-mode' 'eshell' Dmitry Gutov
2021-09-09 5:48 ` Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-09 12:06 ` Dmitry Gutov
2021-09-09 13:09 ` Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-09 23:30 ` Dmitry Gutov
2021-09-10 5:11 ` Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-05 22:06 ` Dmitry Gutov
2021-12-10 10:50 ` jakanakaevangeli
2021-12-10 13:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-13 2:45 ` Dmitry Gutov
2021-12-13 3:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-23 3:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-24 1:50 ` Dmitry Gutov
2022-01-25 23:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 22:29 ` Dmitry Gutov
2022-06-05 0:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-05 0:36 ` Dmitry Gutov
2022-06-05 0:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-05 23:45 ` Dmitry Gutov
2022-06-06 1:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-06 9:07 ` Dmitry Gutov
2022-06-07 15:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-07 22:39 ` Dmitry Gutov
2023-03-17 6:26 ` Jim Porter
2023-03-18 1:01 ` Dmitry Gutov [this message]
2023-03-18 6:36 ` Jim Porter
2023-03-19 18:39 ` Jim Porter
2023-03-20 0:30 ` Jim Porter
2023-03-20 1:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-21 2:30 ` Jim Porter
2023-03-28 0:41 ` Dmitry Gutov
2023-03-28 4:06 ` Jim Porter
2023-03-28 6:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-28 17:43 ` Drew Adams
2023-03-28 19:35 ` Jim Porter
2023-03-28 21:21 ` Dmitry Gutov
2022-06-05 23:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-07 22:10 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru \
--to=dgutov@yandex.ru \
--cc=50470@debbugs.gnu.org \
--cc=ch.bollard@laposte.net \
--cc=johnw@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.