From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Luke Lee <luke.yx.lee@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes
Date: Sun, 29 Jan 2023 21:58:16 -0500 [thread overview]
Message-ID: <jwv357sbur3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org> (Luke Lee's message of "Sun, 29 Jan 2023 11:22:13 -0500 (EST)")
> branch: externals/brief
> commit 362d6296717af611be20cb56592d495c01ea7a00
> Author: Luke Lee <luke@gauss>
> Commit: Luke Lee <luke@gauss>
Please try and use a valid email as commit identifier.
> @@ -457,8 +461,9 @@
> ;; backward compatibility issues.
> ;;(require 'replace)
>
> -(defconst brief-version "5.87"
> - "The version of this Brief emulator.")
> +;;;###autoload
> +(defconst brief-version "5.88.22"
> + "Current version of this Brief editor mode/emulator.")
Why autoload?
> - (not (fboundp 'save-mark-and-excursion)))
> + (not (fboundp #'save-mark-and-excursion)))
The arg to `fboundp` is a symbol not a function (e.g. it can't be
a (lambda ...) for example), so I think #' is ill-advised.
It works fine, in practice, so it's somewhat of a philosophical issue.
> + (when (and (version<= "27.0" emacs-version)
I understand efficiency is not a major issue here, but
(<= 27 emacs-major-version)
works just as well :-)
> - (scroll-bar-mode -1) ;; small border without scroll bar
> + (when (and brief-turn-off-scroll-bar-mode
> + (fboundp #'scroll-bar-mode))
In which circumstance could `scroll-bar-mode` not be defined?
> + (scroll-bar-mode -1) ;; small border without scroll bar
> + (setq-default scroll-bar-mode -1))
According to its doc, the `scroll-bar-mode` variable can take values
`nil`, `left`, and `right`. What do you intend to get by setting it to -1?
Stefan
next prev parent reply other threads:[~2023-01-30 2:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167500933323.27282.16366310039274039148@vcs2.savannah.gnu.org>
[not found] ` <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org>
2023-01-30 2:50 ` [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes Stefan Monnier
2023-01-30 3:01 ` Stefan Monnier
2023-01-30 16:53 ` 路客
2023-01-30 2:58 ` Stefan Monnier [this message]
2023-01-30 17:07 ` 路客
2023-01-30 17:15 ` Stefan Monnier
2023-01-31 15:12 ` 路客
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv357sbur3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=luke.yx.lee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.