From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes Date: Sun, 29 Jan 2023 21:58:16 -0500 Message-ID: References: <167500933323.27282.16366310039274039148@vcs2.savannah.gnu.org> <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31791"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Luke Lee Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 30 03:59:08 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMKNw-00084i-AA for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Jan 2023 03:59:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMKNK-0002A3-IR; Sun, 29 Jan 2023 21:58:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMKNH-00025F-IH for emacs-devel@gnu.org; Sun, 29 Jan 2023 21:58:27 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMKNC-00054I-Mx for emacs-devel@gnu.org; Sun, 29 Jan 2023 21:58:27 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D7AC6441380; Sun, 29 Jan 2023 21:58:20 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6BF25441379; Sun, 29 Jan 2023 21:58:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1675047499; bh=qmIgn2iEtqEtD7zcveHAAavPzB/sRpeAwwF8NpHYLE4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AeEPwJNLBF5em5O5R8gQIJW9ljc3HmWkSiNJHPZECCfbob/ekIgRxqcFY7IkwZBEQ xqVVwg6K2/lk1SFYnC7mTn5U/XX/QtL92sjQhv7MVKs/ok4RejL+yaOBg6eJr/+FjK nvV9tqN5HRC9HeWuMzZdJ+QcGOBPOw9syNkpR33t8z3TGU2Ls45S223r4sv2R/vJz7 hWQlSCtavfYRgtxzt4kJoJxCcnEBvbnjvju3pdcHkUH83M7ZiYYqApB+BK8cnoANnG zxknAC4FXznjjZ2CuTxPmj6bobNTpHO/471mDa40WRy2fIF1Vf+ALiO/pAvN4e78Wx c/+B/e8qGLMJw== Original-Received: from pastel (unknown [167.88.21.243]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4544A120AD9; Sun, 29 Jan 2023 21:58:19 -0500 (EST) In-Reply-To: <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org> (Luke Lee's message of "Sun, 29 Jan 2023 11:22:13 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302770 Archived-At: > branch: externals/brief > commit 362d6296717af611be20cb56592d495c01ea7a00 > Author: Luke Lee > Commit: Luke Lee Please try and use a valid email as commit identifier. > @@ -457,8 +461,9 @@ > ;; backward compatibility issues. > ;;(require 'replace) > > -(defconst brief-version "5.87" > - "The version of this Brief emulator.") > +;;;###autoload > +(defconst brief-version "5.88.22" > + "Current version of this Brief editor mode/emulator.") Why autoload? > - (not (fboundp 'save-mark-and-excursion))) > + (not (fboundp #'save-mark-and-excursion))) The arg to `fboundp` is a symbol not a function (e.g. it can't be a (lambda ...) for example), so I think #' is ill-advised. It works fine, in practice, so it's somewhat of a philosophical issue. > + (when (and (version<= "27.0" emacs-version) I understand efficiency is not a major issue here, but (<= 27 emacs-major-version) works just as well :-) > - (scroll-bar-mode -1) ;; small border without scroll bar > + (when (and brief-turn-off-scroll-bar-mode > + (fboundp #'scroll-bar-mode)) In which circumstance could `scroll-bar-mode` not be defined? > + (scroll-bar-mode -1) ;; small border without scroll bar > + (setq-default scroll-bar-mode -1)) According to its doc, the `scroll-bar-mode` variable can take values `nil`, `left`, and `right`. What do you intend to get by setting it to -1? Stefan