From: 路客 <luke.yx.lee@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes
Date: Tue, 31 Jan 2023 00:53:17 +0800 [thread overview]
Message-ID: <CAA=xLROKJvEtT5SekYsFLtZh7xdo=CN4Y9p1xkMm4pVbokmxVQ@mail.gmail.com> (raw)
In-Reply-To: <jwvwn54afsl.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
Thanks for spotting this. Yes you are right. My local branch
was very different from the one on ELPA and it did not use
nadvice package. Recently I merged ELPA version back and the
code segment you highlighted was quite old and I don't even
remember what it's for, probably a transition code during the
period of transition from `xxx' to `cl-xxx' ...
I've fixed it along with an issue found on the Windows version
-- I just found that the Windows version is a convenient tool to
help me test old Emacs versions like Emacs 24.2.
Thanks.
On Mon, 30 Jan 2023 at 11:01, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> [ Resending with a better email address. ]
>
> > (eval-when-compile
> > - (require 'cl-lib)
> > + (if (version< emacs-version "27.0")
> > + (progn
> > + (require 'cl) ;; Package cl is deprecated for Emacs27+
> > + (require 'cl-macs))
> > + (require 'cl-lib))
>
> This looks like a regression resulting from a misunderstanding.
> What are you trying to do here?
>
> The rest of the code uses only `cl-lib` functionality, so (require 'cl)
> will be useful only if it internally does (require 'cl-lib).
> In Emacs<24.3, this will fail because (require 'cl) will not define the
> macros that the rest of the code needs (e.g. `cl-eval-when`, `cl-loop`,
> ...).
>
>
> Stefan
>
>
--
Best regards,
Luke Lee
[-- Attachment #2: Type: text/html, Size: 2007 bytes --]
next prev parent reply other threads:[~2023-01-30 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167500933323.27282.16366310039274039148@vcs2.savannah.gnu.org>
[not found] ` <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org>
2023-01-30 2:50 ` [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes Stefan Monnier
2023-01-30 3:01 ` Stefan Monnier
2023-01-30 16:53 ` 路客 [this message]
2023-01-30 2:58 ` Stefan Monnier
2023-01-30 17:07 ` 路客
2023-01-30 17:15 ` Stefan Monnier
2023-01-31 15:12 ` 路客
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA=xLROKJvEtT5SekYsFLtZh7xdo=CN4Y9p1xkMm4pVbokmxVQ@mail.gmail.com' \
--to=luke.yx.lee@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.