all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Lars Ingebrigtsen" <larsi@gnus.org>,
	62376@debbugs.gnu.org, "Rudolf Adamkovič" <salutis@me.com>
Subject: bug#62376: 30.0.50; global-display-fill-column-indicator-modes broken?
Date: Wed, 22 Mar 2023 13:52:50 -0400	[thread overview]
Message-ID: <jwv355wznd4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83r0tg6ax2.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Mar 2023 17:52:25 +0200")

>> So, today I customized the
>> 
>> > global-display-fill-column-indicator-modes
>> 
>> variable, and it does not work.

I think it's a thinko in the code: we define the variable but the code
hardcode the var's default value instead of looking up the variable's
actual value.

The patch below should fix it.


        Stefan


diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el
index 5721470ad0d..e84207da2df 100644
--- a/lisp/emacs-lisp/easy-mmode.el
+++ b/lisp/emacs-lisp/easy-mmode.el
@@ -509,7 +509,7 @@ define-globalized-minor-mode
          (setq turn-on-function
                `(lambda ()
                   (require 'easy-mmode)
-                  (when (easy-mmode--globalized-predicate-p ,(car predicate))
+                  (when (easy-mmode--globalized-predicate-p ,MODE-predicate)
                     (funcall ,turn-on-function)))))
         (_ (push keyw extra-keywords) (push (pop body) extra-keywords))))
 






  parent reply	other threads:[~2023-03-22 17:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 12:03 bug#62376: 30.0.50; global-display-fill-column-indicator-modes broken? Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-22 15:52 ` Eli Zaretskii
2023-03-22 16:39   ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-22 17:52   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-03-23  9:04     ` Eli Zaretskii
2023-03-23  9:39       ` Eli Zaretskii
2023-03-23 13:16         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-23 15:11           ` Eli Zaretskii
2023-03-23 17:44             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-27  9:34               ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-27 19:41                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-27 21:18                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv355wznd4.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=62376@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.