From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62376: 30.0.50; global-display-fill-column-indicator-modes broken? Date: Wed, 22 Mar 2023 13:52:50 -0400 Message-ID: References: <83r0tg6ax2.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21167"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Lars Ingebrigtsen , 62376@debbugs.gnu.org, Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 22 18:54:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pf2fB-0005Ho-Iw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Mar 2023 18:54:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pf2ez-0008C6-Qx; Wed, 22 Mar 2023 13:54:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf2ex-0008Bl-Tc for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 13:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pf2ev-0001Ke-RH for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 13:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pf2ev-0007Rc-Nc for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 13:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Mar 2023 17:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62376 X-GNU-PR-Package: emacs Original-Received: via spool by 62376-submit@debbugs.gnu.org id=B62376.167950759928553 (code B ref 62376); Wed, 22 Mar 2023 17:54:01 +0000 Original-Received: (at 62376) by debbugs.gnu.org; 22 Mar 2023 17:53:19 +0000 Original-Received: from localhost ([127.0.0.1]:36663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf2eF-0007QT-E6 for submit@debbugs.gnu.org; Wed, 22 Mar 2023 13:53:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf2eD-0007QB-DE for 62376@debbugs.gnu.org; Wed, 22 Mar 2023 13:53:18 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9BB93100118; Wed, 22 Mar 2023 13:53:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4C5621000BE; Wed, 22 Mar 2023 13:53:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679507585; bh=lnoGmQAWN5XSmzxXawcsPRCxXnPWau8CSbCrZVUZ7dg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=P+y+FnBdSDLUIrKu+z17X03/H6f1ldzEvb0q321cBIOID4MfD9+mYyWvhBRsVfGQy Vmg7FAM8awIi12ShEhuTDSsUZodiEKaZMS1n0zIKkTjYrLTWwpZS3gloVYY9xOEJ8Y 2Hz+WPDdKQmdsd6kLQELO4mVsG2v3R1nTKu13BJ84ASFt1KeBq/9pGkH0tiTbZuQH1 ax+nq/SGYSW9RCb7SzJs0o6Ph1AC1OrV6EO5dJinIdmLr/GG1XLPV+D9DJEHGK7aaf 0MGJFE0zbgHq/RhWZ7MG9uadC1UlP3pbwkKPIGtwhc0lUPxdDaIkXKr1grjWLteiEM p9kyz9X+B1OZQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3A68C123315; Wed, 22 Mar 2023 13:53:05 -0400 (EDT) In-Reply-To: <83r0tg6ax2.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Mar 2023 17:52:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258410 Archived-At: >> So, today I customized the >> >> > global-display-fill-column-indicator-modes >> >> variable, and it does not work. I think it's a thinko in the code: we define the variable but the code hardcode the var's default value instead of looking up the variable's actual value. The patch below should fix it. Stefan diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el index 5721470ad0d..e84207da2df 100644 --- a/lisp/emacs-lisp/easy-mmode.el +++ b/lisp/emacs-lisp/easy-mmode.el @@ -509,7 +509,7 @@ define-globalized-minor-mode (setq turn-on-function `(lambda () (require 'easy-mmode) - (when (easy-mmode--globalized-predicate-p ,(car predicate)) + (when (easy-mmode--globalized-predicate-p ,MODE-predicate) (funcall ,turn-on-function))))) (_ (push keyw extra-keywords) (push (pop body) extra-keywords))))