all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Rudolf Adamkovič" <salutis@me.com>,
	"Lars Ingebrigtsen" <larsi@gnus.org>,
	"Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: 62376@debbugs.gnu.org
Subject: bug#62376: 30.0.50; global-display-fill-column-indicator-modes broken?
Date: Wed, 22 Mar 2023 17:52:25 +0200	[thread overview]
Message-ID: <83r0tg6ax2.fsf@gnu.org> (raw)
In-Reply-To: <m25yat0z9a.fsf@me.com> (bug-gnu-emacs@gnu.org)

> Date: Wed, 22 Mar 2023 13:03:13 +0100
> From:  Rudolf Adamkovič via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> 
> So, today I customized the
> 
> > global-display-fill-column-indicator-modes
> 
> variable, and it does not work.
> 
> I set the variable as per
> 
> > Its value is ((not special-mode java-mode swift-mode kotlin-mode) t)
> > 
> > Original value was
> > ((not special-mode)
> >  t)
> 
> but the fill column indicator shows up in the not-modes listed.

How did you customize it?

> I have also noticed that the help window says
> 
> > global-display-fill-column-indicator-modes is a variable defined in
> > ‘display-fill-column-indicator.el’.
> 
> but the variable is not defined in that source file.

Actually, it is: it is defined as a side effect of
define-globalized-minor-mode call.

(But in my case Emacs says the variable is defined in loaddefs.el,
which is not good.)

> Upon a quick `git grep', it seems that
> 
> - NO TESTS for this functionality EXIST, and

The tests seem to be in test/lisp/emacs-lisp/easy-mmode-tests.el, see
the test easy-mmode--globalized-predicate.  And they pass.

Adding Lars, who wrote that code, and Stefan, in case they have
comments or suggestions.





  reply	other threads:[~2023-03-22 15:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 12:03 bug#62376: 30.0.50; global-display-fill-column-indicator-modes broken? Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-22 15:52 ` Eli Zaretskii [this message]
2023-03-22 16:39   ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-22 17:52   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-23  9:04     ` Eli Zaretskii
2023-03-23  9:39       ` Eli Zaretskii
2023-03-23 13:16         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-23 15:11           ` Eli Zaretskii
2023-03-23 17:44             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-27  9:34               ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-27 19:41                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-27 21:18                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0tg6ax2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62376@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.